summaryrefslogtreecommitdiffhomepage
path: root/runsc
diff options
context:
space:
mode:
authorgVisor bot <gvisor-bot@google.com>2020-09-02 07:42:19 -0700
committergVisor bot <gvisor-bot@google.com>2020-09-02 07:42:19 -0700
commita0e431038477282b95658f104266a7c60ed427db (patch)
tree450d924da28894ac27527efe2d7acd728220b52e /runsc
parent563f28b7d56c11a418856f1defeb64e72beb0e9a (diff)
parent66ee7c0e98a98d4046a23b85af42bc68b5ab6b13 (diff)
Merge pull request #3822 from btw616:fix/issue-3821
PiperOrigin-RevId: 329710371
Diffstat (limited to 'runsc')
-rw-r--r--runsc/boot/loader.go13
1 files changed, 11 insertions, 2 deletions
diff --git a/runsc/boot/loader.go b/runsc/boot/loader.go
index c3c754046..882cf270b 100644
--- a/runsc/boot/loader.go
+++ b/runsc/boot/loader.go
@@ -689,9 +689,18 @@ func (l *Loader) startContainer(spec *specs.Spec, conf *config.Config, cid strin
return fmt.Errorf("creating new process: %v", err)
}
- // setupContainerFS() dups stdioFDs, so we don't need to dup them here.
+ // VFS1 dups stdioFDs, so we don't need to dup them here. VFS2 takes
+ // ownership of the passed FDs, and we need to dup them here.
for _, f := range files[:3] {
- info.stdioFDs = append(info.stdioFDs, int(f.Fd()))
+ if !kernel.VFS2Enabled {
+ info.stdioFDs = append(info.stdioFDs, int(f.Fd()))
+ } else {
+ fd, err := unix.Dup(int(f.Fd()))
+ if err != nil {
+ return fmt.Errorf("failed to dup file: %v", err)
+ }
+ info.stdioFDs = append(info.stdioFDs, fd)
+ }
}
// Can't take ownership away from os.File. dup them to get a new FDs.