diff options
| author | Kevin Krakauer <krakauer@google.com> | 2018-08-22 17:54:18 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2018-08-22 17:55:15 -0700 |
| commit | a78df1d874f376c0924d5a8f91e9e2b5458cca0f (patch) | |
| tree | 22606d9a3de58aa068d958c45f8976be206ace63 /runsc/container | |
| parent | a7a8d07d7d6bd551d96621ee841b1b0e0f217ca3 (diff) | |
runsc: De-flakes container_test TestMultiContainerSanity.
The bug was caused by os.File's finalizer, which closes the file. Because
fsgofer.serve() was passed a file descriptor as an int rather than a os.File,
callers would pass os.File.Fd(), and the os.File would go out of scope. Thus,
the file would get GC'd and finalized nondeterministically, causing failures
when the file was used.
PiperOrigin-RevId: 209861834
Change-Id: Idf24d5c1f04c9b28659e62c97202ab3b4d72e994
Diffstat (limited to 'runsc/container')
| -rw-r--r-- | runsc/container/container_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/runsc/container/container_test.go b/runsc/container/container_test.go index d847dca97..6d84700ce 100644 --- a/runsc/container/container_test.go +++ b/runsc/container/container_test.go @@ -1371,7 +1371,6 @@ func TestAbbreviatedIDs(t *testing.T) { // TestMultiContainerSanity checks that it is possible to run 2 dead-simple // containers in the same sandbox. func TestMultiContainerSanity(t *testing.T) { - t.Skip("Test is flakey.") // TODO: Remove. for _, conf := range configs(all...) { t.Logf("Running test with conf: %+v", conf) |