diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2019-06-03 18:14:52 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2019-06-03 18:16:09 -0700 |
| commit | d28f71adcf60793a81490f3b4d25da36901e769e (patch) | |
| tree | caef4a63a63fb4779be35ffc422825055b641826 /runsc/container/container_test.go | |
| parent | 18e6e63503251cdc0b9432765b6eaa9ffa002824 (diff) | |
Remove 'clearStatus' option from container.Wait*PID()
clearStatus was added to allow detached execution to wait
on the exec'd process and retrieve its exit status. However,
it's not currently used. Both docker and gvisor-containerd-shim
wait on the "shim" process and retrieve the exit status from
there. We could change gvisor-containerd-shim to use waits, but
it will end up also consuming a process for the wait, which is
similar to having the shim process.
Closes #234
PiperOrigin-RevId: 251349490
Diffstat (limited to 'runsc/container/container_test.go')
| -rw-r--r-- | runsc/container/container_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runsc/container/container_test.go b/runsc/container/container_test.go index dcd9910a0..72c5ecbb0 100644 --- a/runsc/container/container_test.go +++ b/runsc/container/container_test.go @@ -1841,7 +1841,7 @@ func (cont *Container) executeSync(args *control.ExecArgs) (syscall.WaitStatus, if err != nil { return 0, fmt.Errorf("error executing: %v", err) } - ws, err := cont.WaitPID(pid, true /* clearStatus */) + ws, err := cont.WaitPID(pid) if err != nil { return 0, fmt.Errorf("error waiting: %v", err) } |