summaryrefslogtreecommitdiffhomepage
path: root/runsc/container/container.go
diff options
context:
space:
mode:
authorIan Lewis <ianlewis@google.com>2020-04-07 18:38:13 -0700
committergVisor bot <gvisor-bot@google.com>2020-04-07 18:39:33 -0700
commit5802051b3d60a802713fabbd805614f22c9291ea (patch)
tree32a3b7facb93cea3ac0dc2e276337f603555350f /runsc/container/container.go
parent5a1324625f1d0d9ea2d4874f9d6d1008ec12f45e (diff)
Update TODO to #238
Move TODO to #238 so that proper synchronization of operations is handled when we create the urpc client. Issue #238 Fixes #512 PiperOrigin-RevId: 305383924
Diffstat (limited to 'runsc/container/container.go')
-rw-r--r--runsc/container/container.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/runsc/container/container.go b/runsc/container/container.go
index c9839044c..7233659b1 100644
--- a/runsc/container/container.go
+++ b/runsc/container/container.go
@@ -1077,9 +1077,9 @@ func (c *Container) adjustGoferOOMScoreAdj() error {
// oom_score_adj is set to the lowest oom_score_adj among the containers
// running in the sandbox.
//
-// TODO(gvisor.dev/issue/512): This call could race with other containers being
+// TODO(gvisor.dev/issue/238): This call could race with other containers being
// created at the same time and end up setting the wrong oom_score_adj to the
-// sandbox.
+// sandbox. Use rpc client to synchronize.
func adjustSandboxOOMScoreAdj(s *sandbox.Sandbox, rootDir string, destroy bool) error {
containers, err := loadSandbox(rootDir, s.ID)
if err != nil {