diff options
| author | Adin Scannell <ascannell@google.com> | 2020-02-05 22:45:44 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-02-05 22:46:35 -0800 |
| commit | 1b6a12a768216a99a5e0428c42ea4faf79cf3b50 (patch) | |
| tree | 995d1ae4ba930d3c6b8fde0f3d1651db472c0dba /runsc/container/console_test.go | |
| parent | f3d95607036b8a502c65aa7b3e8145227274dbbc (diff) | |
Add notes to relevant tests.
These were out-of-band notes that can help provide additional context
and simplify automated imports.
PiperOrigin-RevId: 293525915
Diffstat (limited to 'runsc/container/console_test.go')
| -rw-r--r-- | runsc/container/console_test.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/runsc/container/console_test.go b/runsc/container/console_test.go index 060b63bf3..c2518d52b 100644 --- a/runsc/container/console_test.go +++ b/runsc/container/console_test.go @@ -196,7 +196,10 @@ func TestJobControlSignalExec(t *testing.T) { defer ptyMaster.Close() defer ptySlave.Close() - // Exec bash and attach a terminal. + // Exec bash and attach a terminal. Note that occasionally /bin/sh + // may be a different shell or have a different configuration (such + // as disabling interactive mode and job control). Since we want to + // explicitly test interactive mode, use /bin/bash. See b/116981926. execArgs := &control.ExecArgs{ Filename: "/bin/bash", // Don't let bash execute from profile or rc files, otherwise |