summaryrefslogtreecommitdiffhomepage
path: root/runsc/config
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2021-06-09 15:51:03 -0700
committergVisor bot <gvisor-bot@google.com>2021-06-09 15:53:44 -0700
commit1ca981f50f0b2ad273bbcb870bca21c4b1264504 (patch)
tree5c7be9aba6e67eaa35f80faafd82b66c4c3714a7 /runsc/config
parent2e574a9904cb51119abc015aea5bc45993fa32ec (diff)
Remove --overlayfs-stale-read flag
It defaults to true and setting it to false can cause filesytem corruption. PiperOrigin-RevId: 378518663
Diffstat (limited to 'runsc/config')
-rw-r--r--runsc/config/config.go6
-rw-r--r--runsc/config/flags.go1
2 files changed, 0 insertions, 7 deletions
diff --git a/runsc/config/config.go b/runsc/config/config.go
index fa550ebf7..1ff8e8f67 100644
--- a/runsc/config/config.go
+++ b/runsc/config/config.go
@@ -151,12 +151,6 @@ type Config struct {
// ReferenceLeakMode sets reference leak check mode
ReferenceLeak refs.LeakMode `flag:"ref-leak-mode"`
- // OverlayfsStaleRead instructs the sandbox to assume that the root mount
- // is on a Linux overlayfs mount, which does not necessarily preserve
- // coherence between read-only and subsequent writable file descriptors
- // representing the "same" file.
- OverlayfsStaleRead bool `flag:"overlayfs-stale-read"`
-
// CPUNumFromQuota sets CPU number count to available CPU quota, using
// least integer value greater than or equal to quota.
//
diff --git a/runsc/config/flags.go b/runsc/config/flags.go
index c3dca2352..6f1b5927a 100644
--- a/runsc/config/flags.go
+++ b/runsc/config/flags.go
@@ -72,7 +72,6 @@ func RegisterFlags() {
flag.Var(fileAccessTypePtr(FileAccessShared), "file-access-mounts", "specifies which filesystem validation to use for volumes other than the root mount: shared (default), exclusive.")
flag.Bool("overlay", false, "wrap filesystem mounts with writable overlay. All modifications are stored in memory inside the sandbox.")
flag.Bool("verity", false, "specifies whether a verity file system will be mounted.")
- flag.Bool("overlayfs-stale-read", true, "assume root mount is an overlay filesystem")
flag.Bool("fsgofer-host-uds", false, "allow the gofer to mount Unix Domain Sockets.")
flag.Bool("vfs2", false, "enables VFSv2. This uses the new VFS layer that is faster than the previous one.")
flag.Bool("fuse", false, "TEST ONLY; use while FUSE in VFSv2 is landing. This allows the use of the new experimental FUSE filesystem.")