summaryrefslogtreecommitdiffhomepage
path: root/runsc/config/config.go
diff options
context:
space:
mode:
authorKevin Krakauer <krakauer@google.com>2021-07-08 17:53:49 -0700
committergVisor bot <gvisor-bot@google.com>2021-07-08 17:56:11 -0700
commitf8207a823351055a2aaad633b428fe7c1f0585f0 (patch)
tree6db97f66ae0e3c8a42545f9553b8e6c5cfc84fe2 /runsc/config/config.go
parent052eb90dc15e04dfd8397ca305c507399360dd0e (diff)
clarify safemount behavior
PiperOrigin-RevId: 383750666
Diffstat (limited to 'runsc/config/config.go')
-rw-r--r--runsc/config/config.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/runsc/config/config.go b/runsc/config/config.go
index 3d8c7a0ab..cc4650180 100644
--- a/runsc/config/config.go
+++ b/runsc/config/config.go
@@ -142,7 +142,8 @@ type Config struct {
// Rootless allows the sandbox to be started with a user that is not root.
// Defense in depth measures are weaker in rootless mode. Specifically, the
// sandbox and Gofer process run as root inside a user namespace with root
- // mapped to the caller's user.
+ // mapped to the caller's user. When using rootless, the container root path
+ // should not have a symlink.
Rootless bool `flag:"rootless"`
// AlsoLogToStderr allows to send log messages to stderr.
@@ -175,7 +176,8 @@ type Config struct {
// TestOnlyAllowRunAsCurrentUserWithoutChroot should only be used in
// tests. It allows runsc to start the sandbox process as the current
// user, and without chrooting the sandbox process. This can be
- // necessary in test environments that have limited capabilities.
+ // necessary in test environments that have limited capabilities. When
+ // disabling chroot, the container root path should not have a symlink.
TestOnlyAllowRunAsCurrentUserWithoutChroot bool `flag:"TESTONLY-unsafe-nonroot"`
// TestOnlyTestNameEnv should only be used in tests. It looks up for the