summaryrefslogtreecommitdiffhomepage
path: root/runsc/cmd
diff options
context:
space:
mode:
authorgVisor bot <gvisor-bot@google.com>2019-06-26 18:35:53 +0000
committergVisor bot <gvisor-bot@google.com>2019-06-26 18:35:53 +0000
commit84ea7eac5bd610c7d5dd05b54dcb997a38cb39ee (patch)
tree5c48a9f37c7de3d0ce88b1b34df83ac1bd2cecec /runsc/cmd
parent563b022ea4a0de483ea24d55513558b7c21d1d5e (diff)
parent67e2f227aac49129936efc640a6c47a0978b187d (diff)
Merge 67e2f227 (automated)
Diffstat (limited to 'runsc/cmd')
-rw-r--r--runsc/cmd/exec.go16
1 files changed, 5 insertions, 11 deletions
diff --git a/runsc/cmd/exec.go b/runsc/cmd/exec.go
index 5a823e89a..e817eff77 100644
--- a/runsc/cmd/exec.go
+++ b/runsc/cmd/exec.go
@@ -235,18 +235,12 @@ func (ex *Exec) execChildAndWait(waitStatus *syscall.WaitStatus) subcommands.Exi
cmd.SysProcAttr = &syscall.SysProcAttr{
Setsid: true,
Setctty: true,
- Ctty: int(tty.Fd()),
+ // The Ctty FD must be the FD in the child process's FD
+ // table. Since we set cmd.Stdin/Stdout/Stderr to the
+ // tty FD, we can use any of 0, 1, or 2 here.
+ // See https://github.com/golang/go/issues/29458.
+ Ctty: 0,
}
- // TODO(b/133868570): Delete this check once Go 1.12 is no
- // longer supported.
- if console.CttyFdIsPostShuffle {
- // In go1.12 and before, the Ctty FD must be the FD in
- // the child process's FD table. Since we set
- // cmd.Stdin/Stdout/Stderr to the tty FD, we can use
- // any of 0, 1, or 2 here.
- cmd.SysProcAttr.Ctty = 0
- }
-
}
if err := cmd.Start(); err != nil {