diff options
author | Fabricio Voznika <fvoznika@google.com> | 2019-06-06 10:48:19 -0700 |
---|---|---|
committer | Shentubot <shentubot@google.com> | 2019-06-06 10:49:43 -0700 |
commit | 720ec3590d9bbf6dc2f9533ed5ef2cbc0b01627a (patch) | |
tree | fde2a6a7c707e18c8ae182ef824eb4a5472f2e98 /runsc/cmd/start.go | |
parent | 85be01b42d4ac48698d1e8f50a4cf2607a4fc50b (diff) |
Send error message to docker/kubectl exec on failure
Containerd uses the last error message sent to the log to
print as failure cause for create/exec. This required a
few changes in the logging logic for runsc:
- cmd.Errorf/Fatalf: now writes a message with 'error'
level to containerd log, in addition to stderr and
debug logs, like before.
- log.Infof/Warningf/Fatalf: are not sent to containerd
log anymore. They are mostly used for debugging and not
useful to containerd. In most cases, --debug-log is
enabled and this avoids the logs messages from being
duplicated.
- stderr is not used as default log destination anymore.
Some commands assume stdio is for the container/process
running inside the sandbox and it's better to never use
it for logging. By default, logs are supressed now.
PiperOrigin-RevId: 251881815
Diffstat (limited to 'runsc/cmd/start.go')
-rw-r--r-- | runsc/cmd/start.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/runsc/cmd/start.go b/runsc/cmd/start.go index 657726251..31e8f42bb 100644 --- a/runsc/cmd/start.go +++ b/runsc/cmd/start.go @@ -16,7 +16,6 @@ package cmd import ( "context" - "flag" "github.com/google/subcommands" "gvisor.googlesource.com/gvisor/runsc/boot" |