diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2021-02-22 09:31:32 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-02-22 09:33:46 -0800 |
| commit | 19fe3a2bfb72622c307311dc61019238896a756b (patch) | |
| tree | f2c46a08217feb8cc4d9274ef912342c665d6a29 /runsc/cmd/kill.go | |
| parent | 93fc09248a2fa8b840d8ce47800414980d74bdb0 (diff) | |
Fix `runsc kill --pid`
Previously, loader.signalProcess was inconsitently using both root and
container's PID namespace to find the process. It used root namespace
for the exec'd process and container's PID namespace for other processes.
This fixes the code to use the root PID namespace across the board, which
is the same PID reported in `runsc ps` (or soon will after
https://github.com/google/gvisor/pull/5519).
PiperOrigin-RevId: 358836297
Diffstat (limited to 'runsc/cmd/kill.go')
| -rw-r--r-- | runsc/cmd/kill.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runsc/cmd/kill.go b/runsc/cmd/kill.go index aecf0b7ab..e0df39266 100644 --- a/runsc/cmd/kill.go +++ b/runsc/cmd/kill.go @@ -52,7 +52,7 @@ func (*Kill) Usage() string { // SetFlags implements subcommands.Command.SetFlags. func (k *Kill) SetFlags(f *flag.FlagSet) { f.BoolVar(&k.all, "all", false, "send the specified signal to all processes inside the container") - f.IntVar(&k.pid, "pid", 0, "send the specified signal to a specific process") + f.IntVar(&k.pid, "pid", 0, "send the specified signal to a specific process. pid is relative to the root PID namespace") } // Execute implements subcommands.Command.Execute. |