summaryrefslogtreecommitdiffhomepage
path: root/runsc/cmd/create.go
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2019-06-18 14:45:50 -0700
committergVisor bot <gvisor-bot@google.com>2019-06-18 14:46:49 -0700
commitbdb19b82ef2aa1638d98da4b1c55ae7928437f55 (patch)
treee17a3827341aef639e058893c055dc164f1a247d /runsc/cmd/create.go
parent2e1379867a77bfa94cc740b6d1407d3702810c73 (diff)
Add Container/Sandbox args struct for creation
There were 3 string arguments that could be easily misplaced and it makes it easier to add new arguments, especially for Container that has dozens of callers. PiperOrigin-RevId: 253872074
Diffstat (limited to 'runsc/cmd/create.go')
-rw-r--r--runsc/cmd/create.go10
1 files changed, 9 insertions, 1 deletions
diff --git a/runsc/cmd/create.go b/runsc/cmd/create.go
index 42663c05c..a4e3071b3 100644
--- a/runsc/cmd/create.go
+++ b/runsc/cmd/create.go
@@ -99,7 +99,15 @@ func (c *Create) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}
// Create the container. A new sandbox will be created for the
// container unless the metadata specifies that it should be run in an
// existing container.
- if _, err := container.Create(id, spec, conf, bundleDir, c.consoleSocket, c.pidFile, c.userLog); err != nil {
+ contArgs := container.Args{
+ ID: id,
+ Spec: spec,
+ BundleDir: bundleDir,
+ ConsoleSocket: c.consoleSocket,
+ PIDFile: c.pidFile,
+ UserLog: c.userLog,
+ }
+ if _, err := container.New(conf, contArgs); err != nil {
return Errorf("creating container: %v", err)
}
return subcommands.ExitSuccess