diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2019-01-18 17:35:09 -0800 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2019-01-18 17:36:02 -0800 |
| commit | c1be25b78d89a3a55a32a7aa10724134eda9813d (patch) | |
| tree | bb5c09cb94ab212c158041b260ed0bb480e2a9d5 /runsc/cmd/boot.go | |
| parent | c0a981629cf44688687548490c5e665d851afe06 (diff) | |
Scrub runsc error messages
Removed "error" and "failed to" prefix that don't add value
from messages. Adjusted a few other messages. In particular,
when the container fail to start, the message returned is easier
for humans to read:
$ docker run --rm --runtime=runsc alpine foobar
docker: Error response from daemon: OCI runtime start failed: <path> did not terminate sucessfully: starting container: starting root container [foobar]: starting sandbox: searching for executable "foobar", cwd: "/", $PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin": no such file or directory
Closes #77
PiperOrigin-RevId: 230022798
Change-Id: I83339017c70dae09e4f9f8e0ea2e554c4d5d5cd1
Diffstat (limited to 'runsc/cmd/boot.go')
| -rw-r--r-- | runsc/cmd/boot.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/runsc/cmd/boot.go b/runsc/cmd/boot.go index fb1fd3e70..7f87b2623 100644 --- a/runsc/cmd/boot.go +++ b/runsc/cmd/boot.go @@ -154,7 +154,7 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) defer specFile.Close() spec, err := specutils.ReadSpecFromFile(b.bundleDir, specFile) if err != nil { - Fatalf("error reading spec: %v", err) + Fatalf("reading spec: %v", err) } specutils.LogSpec(spec) @@ -208,7 +208,7 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) } l, err := boot.New(bootArgs) if err != nil { - Fatalf("error creating loader: %v", err) + Fatalf("creating loader: %v", err) } // Fatalf exits the process and doesn't run defers. @@ -220,7 +220,7 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) buf := make([]byte, 1) if w, err := startSyncFile.Write(buf); err != nil || w != 1 { l.Destroy() - Fatalf("Unable to write into the start-sync descriptor: %v", err) + Fatalf("unable to write into the start-sync descriptor: %v", err) } // Closes startSyncFile because 'l.Run()' only returns when the sandbox exits. startSyncFile.Close() @@ -231,7 +231,7 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) // Run the application and wait for it to finish. if err := l.Run(); err != nil { l.Destroy() - Fatalf("error running sandbox: %v", err) + Fatalf("running sandbox: %v", err) } ws := l.WaitExit() |