Add more unimplemented syscall events

Added events for *ctl syscalls that may have multiple different commands.
For runsc, each syscall event is only logged once. For *ctl syscalls, use
the cmd as identifier, not only the syscall number.

PiperOrigin-RevId: 218015941
Change-Id: Ie3c19131ae36124861e9b492a7dbe1765d9e5e59

1 files changed, 66 insertions, 0 deletions

diff --git a/runsc/boot/compat_test.go b/runsc/boot/compat_test.go
new file mode 100644
index 000000000..30b94798a
--- /dev/null
+++ b/runsc/boot/compat_test.go
@@ -0,0 +1,66 @@
+// Copyright 2018 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package boot
+
+import (
+	"testing"
+
+	rpb "gvisor.googlesource.com/gvisor/pkg/sentry/arch/registers_go_proto"
+)
+
+func TestOnceTracker(t *testing.T) {
+	o := onceTracker{}
+	if !o.shouldReport(nil) {
+		t.Error("first call to checkAndMark, got: false, want: true")
+	}
+	o.onReported(nil)
+	for i := 0; i < 2; i++ {
+		if o.shouldReport(nil) {
+			t.Error("after first call to checkAndMark, got: true, want: false")
+		}
+	}
+}
+
+func TestCmdTracker(t *testing.T) {
+	for _, tc := range []struct {
+		name string
+		idx  int
+		rdi1 uint64
+		rdi2 uint64
+		rsi1 uint64
+		rsi2 uint64
+		want bool
+	}{
+		{name: "same rdi", idx: 0, rdi1: 123, rdi2: 123, want: false},
+		{name: "same rsi", idx: 1, rsi1: 123, rsi2: 123, want: false},
+		{name: "diff rdi", idx: 0, rdi1: 123, rdi2: 321, want: true},
+		{name: "diff rsi", idx: 1, rsi1: 123, rsi2: 321, want: true},
+		{name: "cmd is uint32", idx: 0, rsi1: 0xdead00000123, rsi2: 0xbeef00000123, want: false},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			c := newCmdTracker(tc.idx)
+			regs := &rpb.AMD64Registers{Rdi: tc.rdi1, Rsi: tc.rsi1}
+			if !c.shouldReport(regs) {
+				t.Error("first call to checkAndMark, got: false, want: true")
+			}
+			c.onReported(regs)
+
+			regs.Rdi, regs.Rsi = tc.rdi2, tc.rsi2
+			if got := c.shouldReport(regs); tc.want != got {
+				t.Errorf("after first call to checkAndMark, got: %t, want: %t", got, tc.want)
+			}
+		})
+	}
+}