diff options
| author | Tamir Duberstein <tamird@google.com> | 2019-10-18 14:02:52 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2019-10-18 14:10:30 -0700 |
| commit | 4e6f3a0c71e4107efb5c9446508876f942b30ec7 (patch) | |
| tree | 71097b21aae2d788f030204983573fa30df6202a /pkg | |
| parent | 4c7f849b252d43b0d684aeb08e0d54d717fdd7de (diff) | |
Remove restrictions on the sending address
It is quite legal to send from the ANY address (it is required for
DHCP). I can't figure out why the broadcast address was included here,
so removing that as well.
PiperOrigin-RevId: 275541954
Diffstat (limited to 'pkg')
| -rw-r--r-- | pkg/tcpip/network/ipv4/ipv4_test.go | 4 | ||||
| -rw-r--r-- | pkg/tcpip/stack/nic.go | 5 |
2 files changed, 0 insertions, 9 deletions
diff --git a/pkg/tcpip/network/ipv4/ipv4_test.go b/pkg/tcpip/network/ipv4/ipv4_test.go index 85ab0e3bc..99f84acd7 100644 --- a/pkg/tcpip/network/ipv4/ipv4_test.go +++ b/pkg/tcpip/network/ipv4/ipv4_test.go @@ -47,10 +47,6 @@ func TestExcludeBroadcast(t *testing.T) { t.Fatalf("CreateNIC failed: %v", err) } - if err := s.AddAddress(1, ipv4.ProtocolNumber, header.IPv4Any); err != nil { - t.Fatalf("AddAddress failed: %v", err) - } - s.SetRouteTable([]tcpip.Route{{ Destination: header.IPv4EmptySubnet, NIC: 1, diff --git a/pkg/tcpip/stack/nic.go b/pkg/tcpip/stack/nic.go index 43f4ad91e..12c82f8b8 100644 --- a/pkg/tcpip/stack/nic.go +++ b/pkg/tcpip/stack/nic.go @@ -173,11 +173,6 @@ func (n *NIC) primaryEndpoint(protocol tcpip.NetworkProtocolNumber) *referencedN for e := list.Front(); e != nil; e = e.Next() { r := e.(*referencedNetworkEndpoint) - // TODO(crawshaw): allow broadcast address when SO_BROADCAST is set. - switch r.ep.ID().LocalAddress { - case header.IPv4Broadcast, header.IPv4Any: - continue - } if r.isValidForOutgoing() && r.tryIncRef() { return r } |