summaryrefslogtreecommitdiffhomepage
path: root/pkg/tcpip/stack/route.go
diff options
context:
space:
mode:
authorGhanan Gowripalan <ghanan@google.com>2021-01-15 18:12:50 -0800
committergVisor bot <gvisor-bot@google.com>2021-01-15 18:15:26 -0800
commit2814a032be7b34e4cc0c0607dba8030e74e11208 (patch)
treefc6a023766f5ad1ae5818abd710c997ba657e8bd /pkg/tcpip/stack/route.go
parentfd5b52c87ff8fbabf2b293fc95ec9f9f04e5621c (diff)
Support GetLinkAddress with neighborCache
Test: integration_test.TestGetLinkAddress PiperOrigin-RevId: 352119404
Diffstat (limited to 'pkg/tcpip/stack/route.go')
-rw-r--r--pkg/tcpip/stack/route.go22
1 files changed, 3 insertions, 19 deletions
diff --git a/pkg/tcpip/stack/route.go b/pkg/tcpip/stack/route.go
index ac163904c..8dfde488b 100644
--- a/pkg/tcpip/stack/route.go
+++ b/pkg/tcpip/stack/route.go
@@ -51,10 +51,6 @@ type Route struct {
// outgoingNIC is the interface this route uses to write packets.
outgoingNIC *NIC
- // linkCache is set if link address resolution is enabled for this protocol on
- // the route's NIC.
- linkCache LinkAddressCache
-
// linkRes is set if link address resolution is enabled for this protocol on
// the route's NIC.
linkRes LinkAddressResolver
@@ -191,7 +187,6 @@ func makeRouteInner(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr
if r.outgoingNIC.LinkEndpoint.Capabilities()&CapabilityResolutionRequired != 0 {
if linkRes, ok := r.outgoingNIC.stack.linkAddrResolvers[r.NetProto]; ok {
r.linkRes = linkRes
- r.linkCache = r.outgoingNIC.stack
}
}
@@ -338,19 +333,8 @@ func (r *Route) Resolve(afterResolve func()) (<-chan struct{}, *tcpip.Error) {
r.Release()
}
- if neigh := r.outgoingNIC.neigh; neigh != nil {
- _, ch, err := neigh.entry(nextAddr, linkAddressResolutionRequestLocalAddr, r.linkRes, finishResolution)
- if err != nil {
- return ch, err
- }
- return nil, nil
- }
-
- _, ch, err := r.linkCache.GetLinkAddress(r.outgoingNIC.ID(), nextAddr, linkAddressResolutionRequestLocalAddr, r.NetProto, finishResolution)
- if err != nil {
- return ch, err
- }
- return nil, nil
+ _, ch, err := r.outgoingNIC.getNeighborLinkAddress(nextAddr, linkAddressResolutionRequestLocalAddr, r.linkRes, finishResolution)
+ return ch, err
}
// local returns true if the route is a local route.
@@ -373,7 +357,7 @@ func (r *Route) isResolutionRequiredRLocked() bool {
return false
}
- return (r.outgoingNIC.neigh != nil && r.linkRes != nil) || r.linkCache != nil
+ return r.linkRes != nil
}
func (r *Route) isValidForOutgoing() bool {