diff options
| author | Ghanan Gowripalan <ghanan@google.com> | 2020-09-26 19:23:01 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-09-26 19:24:41 -0700 |
| commit | a376a0baf362506549fcc58861465fa89ed33f7f (patch) | |
| tree | 4b804dba7e876522c7f02d0b41145f716d359fef /pkg/tcpip/stack/nic_test.go | |
| parent | ebc81fadfc6797758d63f8290ad3a9c2659ddb49 (diff) | |
Remove generic ICMP errors
Generic ICMP errors were required because the transport dispatcher was
given the responsibility of sending ICMP errors in response to transport
packet delivery failures. Instead, the transport dispatcher should let
network layer know it failed to deliver a packet (and why) and let the
network layer make the decision as to what error to send (if any).
Fixes #4068
PiperOrigin-RevId: 333962333
Diffstat (limited to 'pkg/tcpip/stack/nic_test.go')
| -rw-r--r-- | pkg/tcpip/stack/nic_test.go | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/pkg/tcpip/stack/nic_test.go b/pkg/tcpip/stack/nic_test.go index ef6e63b3e..dd6474297 100644 --- a/pkg/tcpip/stack/nic_test.go +++ b/pkg/tcpip/stack/nic_test.go @@ -221,11 +221,6 @@ func (*testIPv6Protocol) Parse(*PacketBuffer) (tcpip.TransportProtocolNumber, bo return 0, false, false } -// ReturnError implements NetworkProtocol.ReturnError. -func (*testIPv6Protocol) ReturnError(*Route, tcpip.ICMPReason, *PacketBuffer) *tcpip.Error { - return nil -} - var _ LinkAddressResolver = (*testIPv6Protocol)(nil) // LinkAddressProtocol implements LinkAddressResolver. |