diff options
| author | Ghanan Gowripalan <ghanan@google.com> | 2020-09-26 19:23:01 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-09-26 19:24:41 -0700 |
| commit | a376a0baf362506549fcc58861465fa89ed33f7f (patch) | |
| tree | 4b804dba7e876522c7f02d0b41145f716d359fef /pkg/tcpip/network/arp | |
| parent | ebc81fadfc6797758d63f8290ad3a9c2659ddb49 (diff) | |
Remove generic ICMP errors
Generic ICMP errors were required because the transport dispatcher was
given the responsibility of sending ICMP errors in response to transport
packet delivery failures. Instead, the transport dispatcher should let
network layer know it failed to deliver a packet (and why) and let the
network layer make the decision as to what error to send (if any).
Fixes #4068
PiperOrigin-RevId: 333962333
Diffstat (limited to 'pkg/tcpip/network/arp')
| -rw-r--r-- | pkg/tcpip/network/arp/arp.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/pkg/tcpip/network/arp/arp.go b/pkg/tcpip/network/arp/arp.go index 81e286e80..cb9225bd7 100644 --- a/pkg/tcpip/network/arp/arp.go +++ b/pkg/tcpip/network/arp/arp.go @@ -238,12 +238,6 @@ func (*protocol) Parse(pkt *stack.PacketBuffer) (proto tcpip.TransportProtocolNu return 0, false, parse.ARP(pkt) } -// ReturnError implements stack.TransportProtocol.ReturnError. -func (*protocol) ReturnError(*stack.Route, tcpip.ICMPReason, *stack.PacketBuffer) *tcpip.Error { - // In ARP, there is no such response so do nothing. - return nil -} - // NewProtocol returns an ARP network protocol. func NewProtocol() stack.NetworkProtocol { return &protocol{} |