diff options
| author | Bert Muthalaly <stijlist@google.com> | 2018-09-05 17:33:18 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2018-09-05 17:34:25 -0700 |
| commit | 5685d6b5add2acce9618aa908b846f5ce3658346 (patch) | |
| tree | ca93fb55c83ebf77806957c73c3951fc01844560 /pkg/tcpip/link/channel/channel.go | |
| parent | fe8ca76c22ff03c9ae8bf524031553d65b30f53d (diff) | |
Update {LinkEndpoint,NetworkEndpoint}#WritePacket to take a VectorisedView
Makes it possible to avoid copying or allocating in cases where DeliverNetworkPacket (rx)
needs to turn around and call WritePacket (tx) with its VectorisedView.
Also removes the restriction on having VectorisedViews with multiple views in the write path.
PiperOrigin-RevId: 211728717
Change-Id: Ie03a65ecb4e28bd15ebdb9c69f05eced18fdfcff
Diffstat (limited to 'pkg/tcpip/link/channel/channel.go')
| -rw-r--r-- | pkg/tcpip/link/channel/channel.go | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/pkg/tcpip/link/channel/channel.go b/pkg/tcpip/link/channel/channel.go index dd3fe7c87..6983fae3f 100644 --- a/pkg/tcpip/link/channel/channel.go +++ b/pkg/tcpip/link/channel/channel.go @@ -111,15 +111,11 @@ func (e *Endpoint) LinkAddress() tcpip.LinkAddress { } // WritePacket stores outbound packets into the channel. -func (e *Endpoint) WritePacket(_ *stack.Route, hdr *buffer.Prependable, payload buffer.View, protocol tcpip.NetworkProtocolNumber) *tcpip.Error { +func (e *Endpoint) WritePacket(_ *stack.Route, hdr *buffer.Prependable, payload buffer.VectorisedView, protocol tcpip.NetworkProtocolNumber) *tcpip.Error { p := PacketInfo{ - Header: hdr.View(), - Proto: protocol, - } - - if payload != nil { - p.Payload = make(buffer.View, len(payload)) - copy(p.Payload, payload) + Header: hdr.View(), + Proto: protocol, + Payload: payload.ToView(), } select { |