diff options
| author | Julian Elischer <jrelis@google.com> | 2021-01-20 15:33:53 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-01-20 15:36:03 -0800 |
| commit | 2865166403896a668167678ba0a8c2ef24268ca0 (patch) | |
| tree | a27432b3ce33de82472adf4e56f3ec6832f90e08 /pkg/tcpip/checker/checker.go | |
| parent | 7ff5ceaeae66303ed6a2199963c00cb08b2fe7ca (diff) | |
Change the way the IP options report problems
The error messages are not needed or used as these are not processing errors
so much as errors to be reported back to the packet sender. Implicitly
describe whether each error should generate ICMP packets or not. Most do
but there are a couple that do not.
Slightly alter some test expectations for Linux compatibility and add a
couple more. Improve Linux compatibility on error packet returns. Some
cosmetic changes to tests to match the upcoming packet impact version
of the same tests.
PiperOrigin-RevId: 352889785
Diffstat (limited to 'pkg/tcpip/checker/checker.go')
| -rw-r--r-- | pkg/tcpip/checker/checker.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkg/tcpip/checker/checker.go b/pkg/tcpip/checker/checker.go index 0ac2000ca..07b4393a4 100644 --- a/pkg/tcpip/checker/checker.go +++ b/pkg/tcpip/checker/checker.go @@ -1,4 +1,4 @@ -// Copyright 2018 The gVisor Authors. +// Copyright 2021 The gVisor Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -234,7 +234,7 @@ func IPv4RouterAlert() NetworkChecker { for { opt, done, err := iterator.Next() if err != nil { - t.Fatalf("error acquiring next IPv4 option %s", err) + t.Fatalf("error acquiring next IPv4 option at offset %d", err.Pointer) } if done { break |