diff options
author | Zach Koopmans <zkoopmans@google.com> | 2021-08-13 15:26:44 -0700 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2021-08-13 15:29:11 -0700 |
commit | 868ed0e807239635bd3aa6b964bb4fc0913916be (patch) | |
tree | 250709e4e68f3b575ef8250246f3832feef15fd9 /pkg/syserr/syserr.go | |
parent | 6eb8596f72f3c889de3f826b82319d41ac655829 (diff) |
[benchmarks] Update BenchmarkStartEmpty benchmark.
Update the start benchmark on empty to only "Start" a container, not wait
for its completion.
TL:DR only measure the actual start call for the empty container.
Previously, we were measuring the completion of /bin/true in container
alpine AND the cleanup. This was fine until profiling started failing all
the time on ptrace. This is a cost that runc is not paying.
These changes will reduce the over all timing of the benchmark, but it will
give more sane results.
Instead, use "Spawn" which is similar to `docker run --detach alpine
/bin/sleep 100`. Call sleep so containers stick around long enough
for the profiler to read profile data from them.
PiperOrigin-RevId: 390705431
Diffstat (limited to 'pkg/syserr/syserr.go')
0 files changed, 0 insertions, 0 deletions