summaryrefslogtreecommitdiffhomepage
path: root/pkg/shim/v1/proc/utils.go
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2020-11-12 19:09:43 -0800
committergVisor bot <gvisor-bot@google.com>2020-11-12 19:11:35 -0800
commitcf47c8b4a5d22f317cb88ee1c11b5c695c508d1f (patch)
treee28206c955aca312be54ed88c17a8f7d5642957a /pkg/shim/v1/proc/utils.go
parent638d64c6337d05b91f0bde81de8e1c8d6d9908d8 (diff)
Improve shim debug logging
- Add log statements in service entry points. - Propagate `-debug` flag from shim invokation to the service - Load options when shim process is invoked to ensure runsc commands use the correct set of options, e.g. --debug --debug-logs=... - Add debug options to the shim configuration directly, so it doesn't rely on containerd configuration (and restart) to enable shim debug. - Save shim logs to dedicated file, so it's easier to read logs. They would be mixed with containerd logs and hard to distinguish otherwise. PiperOrigin-RevId: 342179868
Diffstat (limited to 'pkg/shim/v1/proc/utils.go')
-rw-r--r--pkg/shim/v1/proc/utils.go18
1 files changed, 0 insertions, 18 deletions
diff --git a/pkg/shim/v1/proc/utils.go b/pkg/shim/v1/proc/utils.go
index 716de2f59..7c2c409af 100644
--- a/pkg/shim/v1/proc/utils.go
+++ b/pkg/shim/v1/proc/utils.go
@@ -67,24 +67,6 @@ func getLastRuntimeError(r *runsc.Runsc) (string, error) {
return errMsg, nil
}
-func copyFile(to, from string) error {
- ff, err := os.Open(from)
- if err != nil {
- return err
- }
- defer ff.Close()
- tt, err := os.Create(to)
- if err != nil {
- return err
- }
- defer tt.Close()
-
- p := bufPool.Get().(*[]byte)
- defer bufPool.Put(p)
- _, err = io.CopyBuffer(tt, ff, *p)
- return err
-}
-
func hasNoIO(r *CreateConfig) bool {
return r.Stdin == "" && r.Stdout == "" && r.Stderr == ""
}