[syserror] Update syserror to linuxerr for more errors.

Update the following from syserror to the linuxerr equivalent:
EEXIST
EFAULT
ENOTDIR
ENOTTY
EOPNOTSUPP
ERANGE
ESRCH

PiperOrigin-RevId: 384329869

7 files changed, 34 insertions, 37 deletions

diff --git a/pkg/sentry/vfs/anonfs.go b/pkg/sentry/vfs/anonfs.go
index 40863cbb6..255d3992e 100644
--- a/pkg/sentry/vfs/anonfs.go
+++ b/pkg/sentry/vfs/anonfs.go
@@ -24,7 +24,6 @@ import (
 	"gvisor.dev/gvisor/pkg/hostarch"
 	"gvisor.dev/gvisor/pkg/sentry/kernel/auth"
 	"gvisor.dev/gvisor/pkg/sentry/socket/unix/transport"
-	"gvisor.dev/gvisor/pkg/syserror"
 )
 
 // NewAnonVirtualDentry returns a VirtualDentry with the given synthetic name,
@@ -102,7 +101,7 @@ func (fs *anonFilesystem) Sync(ctx context.Context) error {
 // AccessAt implements vfs.Filesystem.Impl.AccessAt.
 func (fs *anonFilesystem) AccessAt(ctx context.Context, rp *ResolvingPath, creds *auth.Credentials, ats AccessTypes) error {
 	if !rp.Done() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return GenericCheckPermissions(creds, ats, anonFileMode, anonFileUID, anonFileGID)
 }
@@ -110,10 +109,10 @@ func (fs *anonFilesystem) AccessAt(ctx context.Context, rp *ResolvingPath, creds
 // GetDentryAt implements FilesystemImpl.GetDentryAt.
 func (fs *anonFilesystem) GetDentryAt(ctx context.Context, rp *ResolvingPath, opts GetDentryOptions) (*Dentry, error) {
 	if !rp.Done() {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	if opts.CheckSearchable {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	// anonDentry no-ops refcounting.
 	return rp.Start(), nil
@@ -122,7 +121,7 @@ func (fs *anonFilesystem) GetDentryAt(ctx context.Context, rp *ResolvingPath, op
 // GetParentDentryAt implements FilesystemImpl.GetParentDentryAt.
 func (fs *anonFilesystem) GetParentDentryAt(ctx context.Context, rp *ResolvingPath) (*Dentry, error) {
 	if !rp.Final() {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	// anonDentry no-ops refcounting.
 	return rp.Start(), nil
@@ -131,7 +130,7 @@ func (fs *anonFilesystem) GetParentDentryAt(ctx context.Context, rp *ResolvingPa
 // LinkAt implements FilesystemImpl.LinkAt.
 func (fs *anonFilesystem) LinkAt(ctx context.Context, rp *ResolvingPath, vd VirtualDentry) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -139,7 +138,7 @@ func (fs *anonFilesystem) LinkAt(ctx context.Context, rp *ResolvingPath, vd Virt
 // MkdirAt implements FilesystemImpl.MkdirAt.
 func (fs *anonFilesystem) MkdirAt(ctx context.Context, rp *ResolvingPath, opts MkdirOptions) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -147,7 +146,7 @@ func (fs *anonFilesystem) MkdirAt(ctx context.Context, rp *ResolvingPath, opts M
 // MknodAt implements FilesystemImpl.MknodAt.
 func (fs *anonFilesystem) MknodAt(ctx context.Context, rp *ResolvingPath, opts MknodOptions) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -155,7 +154,7 @@ func (fs *anonFilesystem) MknodAt(ctx context.Context, rp *ResolvingPath, opts M
 // OpenAt implements FilesystemImpl.OpenAt.
 func (fs *anonFilesystem) OpenAt(ctx context.Context, rp *ResolvingPath, opts OpenOptions) (*FileDescription, error) {
 	if !rp.Done() {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	return nil, linuxerr.ENODEV
 }
@@ -163,7 +162,7 @@ func (fs *anonFilesystem) OpenAt(ctx context.Context, rp *ResolvingPath, opts Op
 // ReadlinkAt implements FilesystemImpl.ReadlinkAt.
 func (fs *anonFilesystem) ReadlinkAt(ctx context.Context, rp *ResolvingPath) (string, error) {
 	if !rp.Done() {
-		return "", syserror.ENOTDIR
+		return "", linuxerr.ENOTDIR
 	}
 	return "", linuxerr.EINVAL
 }
@@ -171,7 +170,7 @@ func (fs *anonFilesystem) ReadlinkAt(ctx context.Context, rp *ResolvingPath) (st
 // RenameAt implements FilesystemImpl.RenameAt.
 func (fs *anonFilesystem) RenameAt(ctx context.Context, rp *ResolvingPath, oldParentVD VirtualDentry, oldName string, opts RenameOptions) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -179,7 +178,7 @@ func (fs *anonFilesystem) RenameAt(ctx context.Context, rp *ResolvingPath, oldPa
 // RmdirAt implements FilesystemImpl.RmdirAt.
 func (fs *anonFilesystem) RmdirAt(ctx context.Context, rp *ResolvingPath) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -187,7 +186,7 @@ func (fs *anonFilesystem) RmdirAt(ctx context.Context, rp *ResolvingPath) error
 // SetStatAt implements FilesystemImpl.SetStatAt.
 func (fs *anonFilesystem) SetStatAt(ctx context.Context, rp *ResolvingPath, opts SetStatOptions) error {
 	if !rp.Done() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	// Linux actually permits anon_inode_inode's metadata to be set, which is
 	// visible to all users of anon_inode_inode. We just silently ignore
@@ -198,7 +197,7 @@ func (fs *anonFilesystem) SetStatAt(ctx context.Context, rp *ResolvingPath, opts
 // StatAt implements FilesystemImpl.StatAt.
 func (fs *anonFilesystem) StatAt(ctx context.Context, rp *ResolvingPath, opts StatOptions) (linux.Statx, error) {
 	if !rp.Done() {
-		return linux.Statx{}, syserror.ENOTDIR
+		return linux.Statx{}, linuxerr.ENOTDIR
 	}
 	// See fs/anon_inodes.c:anon_inode_init() => fs/libfs.c:alloc_anon_inode().
 	return linux.Statx{
@@ -219,7 +218,7 @@ func (fs *anonFilesystem) StatAt(ctx context.Context, rp *ResolvingPath, opts St
 // StatFSAt implements FilesystemImpl.StatFSAt.
 func (fs *anonFilesystem) StatFSAt(ctx context.Context, rp *ResolvingPath) (linux.Statfs, error) {
 	if !rp.Done() {
-		return linux.Statfs{}, syserror.ENOTDIR
+		return linux.Statfs{}, linuxerr.ENOTDIR
 	}
 	return linux.Statfs{
 		Type:      linux.ANON_INODE_FS_MAGIC,
@@ -230,7 +229,7 @@ func (fs *anonFilesystem) StatFSAt(ctx context.Context, rp *ResolvingPath) (linu
 // SymlinkAt implements FilesystemImpl.SymlinkAt.
 func (fs *anonFilesystem) SymlinkAt(ctx context.Context, rp *ResolvingPath, target string) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -238,7 +237,7 @@ func (fs *anonFilesystem) SymlinkAt(ctx context.Context, rp *ResolvingPath, targ
 // UnlinkAt implements FilesystemImpl.UnlinkAt.
 func (fs *anonFilesystem) UnlinkAt(ctx context.Context, rp *ResolvingPath) error {
 	if !rp.Final() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -246,7 +245,7 @@ func (fs *anonFilesystem) UnlinkAt(ctx context.Context, rp *ResolvingPath) error
 // BoundEndpointAt implements FilesystemImpl.BoundEndpointAt.
 func (fs *anonFilesystem) BoundEndpointAt(ctx context.Context, rp *ResolvingPath, opts BoundEndpointOptions) (transport.BoundEndpoint, error) {
 	if !rp.Final() {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	if err := GenericCheckPermissions(rp.Credentials(), MayWrite, anonFileMode, anonFileUID, anonFileGID); err != nil {
 		return nil, err
@@ -257,7 +256,7 @@ func (fs *anonFilesystem) BoundEndpointAt(ctx context.Context, rp *ResolvingPath
 // ListXattrAt implements FilesystemImpl.ListXattrAt.
 func (fs *anonFilesystem) ListXattrAt(ctx context.Context, rp *ResolvingPath, size uint64) ([]string, error) {
 	if !rp.Done() {
-		return nil, syserror.ENOTDIR
+		return nil, linuxerr.ENOTDIR
 	}
 	return nil, nil
 }
@@ -265,7 +264,7 @@ func (fs *anonFilesystem) ListXattrAt(ctx context.Context, rp *ResolvingPath, si
 // GetXattrAt implements FilesystemImpl.GetXattrAt.
 func (fs *anonFilesystem) GetXattrAt(ctx context.Context, rp *ResolvingPath, opts GetXattrOptions) (string, error) {
 	if !rp.Done() {
-		return "", syserror.ENOTDIR
+		return "", linuxerr.ENOTDIR
 	}
 	return "", linuxerr.ENOTSUP
 }
@@ -273,7 +272,7 @@ func (fs *anonFilesystem) GetXattrAt(ctx context.Context, rp *ResolvingPath, opt
 // SetXattrAt implements FilesystemImpl.SetXattrAt.
 func (fs *anonFilesystem) SetXattrAt(ctx context.Context, rp *ResolvingPath, opts SetXattrOptions) error {
 	if !rp.Done() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
@@ -281,7 +280,7 @@ func (fs *anonFilesystem) SetXattrAt(ctx context.Context, rp *ResolvingPath, opt
 // RemoveXattrAt implements FilesystemImpl.RemoveXattrAt.
 func (fs *anonFilesystem) RemoveXattrAt(ctx context.Context, rp *ResolvingPath, name string) error {
 	if !rp.Done() {
-		return syserror.ENOTDIR
+		return linuxerr.ENOTDIR
 	}
 	return linuxerr.EPERM
 }
diff --git a/pkg/sentry/vfs/epoll.go b/pkg/sentry/vfs/epoll.go
index a93e757f8..befe3ca25 100644
--- a/pkg/sentry/vfs/epoll.go
+++ b/pkg/sentry/vfs/epoll.go
@@ -188,7 +188,7 @@ func (ep *EpollInstance) AddInterest(file *FileDescription, num int32, event lin
 		num:  num,
 	}
 	if _, ok := ep.interest[key]; ok {
-		return syserror.EEXIST
+		return linuxerr.EEXIST
 	}
 
 	// Register interest in file.
diff --git a/pkg/sentry/vfs/file_description_impl_util.go b/pkg/sentry/vfs/file_description_impl_util.go
index c1ab2f56c..a875fdeca 100644
--- a/pkg/sentry/vfs/file_description_impl_util.go
+++ b/pkg/sentry/vfs/file_description_impl_util.go
@@ -114,7 +114,7 @@ func (FileDescriptionDefaultImpl) Write(ctx context.Context, src usermem.IOSeque
 // file_operations::iterate == file_operations::iterate_shared == NULL in
 // Linux.
 func (FileDescriptionDefaultImpl) IterDirents(ctx context.Context, cb IterDirentsCallback) error {
-	return syserror.ENOTDIR
+	return linuxerr.ENOTDIR
 }
 
 // Seek implements FileDescriptionImpl.Seek analogously to
@@ -138,7 +138,7 @@ func (FileDescriptionDefaultImpl) ConfigureMMap(ctx context.Context, opts *memma
 // Ioctl implements FileDescriptionImpl.Ioctl analogously to
 // file_operations::unlocked_ioctl == NULL in Linux.
 func (FileDescriptionDefaultImpl) Ioctl(ctx context.Context, uio usermem.IO, args arch.SyscallArguments) (uintptr, error) {
-	return 0, syserror.ENOTTY
+	return 0, linuxerr.ENOTTY
 }
 
 // ListXattr implements FileDescriptionImpl.ListXattr analogously to
@@ -358,7 +358,7 @@ func (fd *DynamicBytesFileDescriptionImpl) Seek(ctx context.Context, offset int6
 // Preconditions: fd.mu must be locked.
 func (fd *DynamicBytesFileDescriptionImpl) pwriteLocked(ctx context.Context, src usermem.IOSequence, offset int64, opts WriteOptions) (int64, error) {
 	if opts.Flags&^(linux.RWF_HIPRI|linux.RWF_DSYNC|linux.RWF_SYNC) != 0 {
-		return 0, syserror.EOPNOTSUPP
+		return 0, linuxerr.EOPNOTSUPP
 	}
 	limit, err := CheckLimit(ctx, offset, src.NumBytes())
 	if err != nil {
diff --git a/pkg/sentry/vfs/inotify.go b/pkg/sentry/vfs/inotify.go
index e0624b2fa..088beb8e2 100644
--- a/pkg/sentry/vfs/inotify.go
+++ b/pkg/sentry/vfs/inotify.go
@@ -263,7 +263,7 @@ func (i *Inotify) Ioctl(ctx context.Context, uio usermem.IO, args arch.SyscallAr
 		return 0, err
 
 	default:
-		return 0, syserror.ENOTTY
+		return 0, linuxerr.ENOTTY
 	}
 }
 
diff --git a/pkg/sentry/vfs/memxattr/BUILD b/pkg/sentry/vfs/memxattr/BUILD
index 49127896c..444ab42b9 100644
--- a/pkg/sentry/vfs/memxattr/BUILD
+++ b/pkg/sentry/vfs/memxattr/BUILD
@@ -12,6 +12,5 @@ go_library(
         "//pkg/sentry/kernel/auth",
         "//pkg/sentry/vfs",
         "//pkg/sync",
-        "//pkg/syserror",
     ],
 )
diff --git a/pkg/sentry/vfs/memxattr/xattr.go b/pkg/sentry/vfs/memxattr/xattr.go
index efc9c6a5d..f0f82a4d6 100644
--- a/pkg/sentry/vfs/memxattr/xattr.go
+++ b/pkg/sentry/vfs/memxattr/xattr.go
@@ -24,7 +24,6 @@ import (
 	"gvisor.dev/gvisor/pkg/sentry/kernel/auth"
 	"gvisor.dev/gvisor/pkg/sentry/vfs"
 	"gvisor.dev/gvisor/pkg/sync"
-	"gvisor.dev/gvisor/pkg/syserror"
 )
 
 // SimpleExtendedAttributes implements extended attributes using a map of
@@ -55,7 +54,7 @@ func (x *SimpleExtendedAttributes) GetXattr(creds *auth.Credentials, mode linux.
 	// Check that the size of the buffer provided in getxattr(2) is large enough
 	// to contain the value.
 	if opts.Size != 0 && uint64(len(value)) > opts.Size {
-		return "", syserror.ERANGE
+		return "", linuxerr.ERANGE
 	}
 	return value, nil
 }
@@ -77,7 +76,7 @@ func (x *SimpleExtendedAttributes) SetXattr(creds *auth.Credentials, mode linux.
 
 	_, ok := x.xattrs[opts.Name]
 	if ok && opts.Flags&linux.XATTR_CREATE != 0 {
-		return syserror.EEXIST
+		return linuxerr.EEXIST
 	}
 	if !ok && opts.Flags&linux.XATTR_REPLACE != 0 {
 		return linuxerr.ENODATA
@@ -107,7 +106,7 @@ func (x *SimpleExtendedAttributes) ListXattr(creds *auth.Credentials, size uint6
 	}
 	x.mu.RUnlock()
 	if size != 0 && uint64(listSize) > size {
-		return nil, syserror.ERANGE
+		return nil, linuxerr.ERANGE
 	}
 	return names, nil
 }
diff --git a/pkg/sentry/vfs/vfs.go b/pkg/sentry/vfs/vfs.go
index cb9ed81d8..aeca262e3 100644
--- a/pkg/sentry/vfs/vfs.go
+++ b/pkg/sentry/vfs/vfs.go
@@ -279,7 +279,7 @@ func (vfs *VirtualFilesystem) LinkAt(ctx context.Context, creds *auth.Credential
 	if !newpop.Path.Begin.Ok() {
 		oldVD.DecRef(ctx)
 		if newpop.Path.Absolute {
-			return syserror.EEXIST
+			return linuxerr.EEXIST
 		}
 		return syserror.ENOENT
 	}
@@ -316,7 +316,7 @@ func (vfs *VirtualFilesystem) MkdirAt(ctx context.Context, creds *auth.Credentia
 		// pop.Path should not be empty in operations that create/delete files.
 		// This is consistent with mkdirat(dirfd, "", mode).
 		if pop.Path.Absolute {
-			return syserror.EEXIST
+			return linuxerr.EEXIST
 		}
 		return syserror.ENOENT
 	}
@@ -354,7 +354,7 @@ func (vfs *VirtualFilesystem) MknodAt(ctx context.Context, creds *auth.Credentia
 		// pop.Path should not be empty in operations that create/delete files.
 		// This is consistent with mknodat(dirfd, "", mode, dev).
 		if pop.Path.Absolute {
-			return syserror.EEXIST
+			return linuxerr.EEXIST
 		}
 		return syserror.ENOENT
 	}
@@ -639,7 +639,7 @@ func (vfs *VirtualFilesystem) SymlinkAt(ctx context.Context, creds *auth.Credent
 		// pop.Path should not be empty in operations that create/delete files.
 		// This is consistent with symlinkat(oldpath, newdirfd, "").
 		if pop.Path.Absolute {
-			return syserror.EEXIST
+			return linuxerr.EEXIST
 		}
 		return syserror.ENOENT
 	}
@@ -834,7 +834,7 @@ func (vfs *VirtualFilesystem) MkdirAllAt(ctx context.Context, currentPath string
 	switch {
 	case err == nil:
 		if stat.Mask&linux.STATX_TYPE == 0 || stat.Mode&linux.FileTypeMask != linux.ModeDirectory {
-			return syserror.ENOTDIR
+			return linuxerr.ENOTDIR
 		}
 		// Directory already exists.
 		return nil