summaryrefslogtreecommitdiffhomepage
path: root/pkg/sentry/syscalls/linux
diff options
context:
space:
mode:
authorChristopher Koch <chrisko@google.com>2018-05-16 13:28:29 -0700
committerShentubot <shentubot@google.com>2018-05-16 13:29:17 -0700
commitd154c6a25f9d2b88b8ce22cff575467b159f06bc (patch)
tree05aa54a07e0328861c097cf1ccaa7aa315375c2a /pkg/sentry/syscalls/linux
parentf295e26b8abe395eaf1d4bee9a792a79b34d156f (diff)
Refcount socket Dirents correctly.
This should fix the socket Dirent memory leak. fs.NewFile takes a new reference. It should hold the *only* reference. DecRef that socket Dirent. Before the globalDirentMap was introduced, a mis-refcounted Dirent would be garbage collected when all references to it were gone. For socket Dirents, this meant that they would be garbage collected when the associated fs.Files disappeared. After the globalDirentMap, Dirents *must* be reference-counted correctly to be garbage collected, as Dirents remove themselves from the global map when their refcount goes to -1 (see Dirent.destroy). That removes the last pointer to that Dirent. PiperOrigin-RevId: 196878973 Change-Id: Ic7afcd1de97c7101ccb13be5fc31de0fb50963f0
Diffstat (limited to 'pkg/sentry/syscalls/linux')
0 files changed, 0 insertions, 0 deletions