diff options
| author | Ting-Yu Wang <anivia@google.com> | 2020-04-07 14:32:24 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-04-07 14:33:48 -0700 |
| commit | d5ddb5365086b13c0688c40fc74fa4cc4c5528db (patch) | |
| tree | 181285f7d4dcf39fd0514611c74dd00d261c2f0b /pkg/sentry/socket/netstack/provider.go | |
| parent | 47db097773f9c0badb9f7b5866e697a7e7d0da13 (diff) | |
Remove out-of-date TODOs.
We already have network namespace for netstack.
PiperOrigin-RevId: 305341954
Diffstat (limited to 'pkg/sentry/socket/netstack/provider.go')
| -rw-r--r-- | pkg/sentry/socket/netstack/provider.go | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/pkg/sentry/socket/netstack/provider.go b/pkg/sentry/socket/netstack/provider.go index eb090e79b..c3f04b613 100644 --- a/pkg/sentry/socket/netstack/provider.go +++ b/pkg/sentry/socket/netstack/provider.go @@ -62,10 +62,6 @@ func getTransportProtocol(ctx context.Context, stype linux.SockType, protocol in } case linux.SOCK_RAW: - // TODO(b/142504697): "In order to create a raw socket, a - // process must have the CAP_NET_RAW capability in the user - // namespace that governs its network namespace." - raw(7) - // Raw sockets require CAP_NET_RAW. creds := auth.CredentialsFromContext(ctx) if !creds.HasCapability(linux.CAP_NET_RAW) { @@ -141,10 +137,6 @@ func (p *provider) Socket(t *kernel.Task, stype linux.SockType, protocol int) (* } func packetSocket(t *kernel.Task, epStack *Stack, stype linux.SockType, protocol int) (*fs.File, *syserr.Error) { - // TODO(b/142504697): "In order to create a packet socket, a process - // must have the CAP_NET_RAW capability in the user namespace that - // governs its network namespace." - packet(7) - // Packet sockets require CAP_NET_RAW. creds := auth.CredentialsFromContext(t) if !creds.HasCapability(linux.CAP_NET_RAW) { |