diff options
| author | gVisor bot <gvisor-bot@google.com> | 2020-05-05 19:14:09 +0000 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-05-05 19:14:09 +0000 |
| commit | 129633d5d7e16d74923fa97d6d1ac02d8fb8de1c (patch) | |
| tree | e9fee90521244450854874ab62e71d9b8e5ba06f /pkg/sentry/socket/hostinet | |
| parent | 2e0241989cbd0c035766917abcadacdf58921fc0 (diff) | |
| parent | faf89dd31a44b8409b32919d7193834e194ecc56 (diff) | |
Merge release-20200422.0-29-gfaf89dd (automated)
Diffstat (limited to 'pkg/sentry/socket/hostinet')
| -rwxr-xr-x | pkg/sentry/socket/hostinet/socket_vfs2.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/pkg/sentry/socket/hostinet/socket_vfs2.go b/pkg/sentry/socket/hostinet/socket_vfs2.go index b03ca2f26..a8278bffc 100755 --- a/pkg/sentry/socket/hostinet/socket_vfs2.go +++ b/pkg/sentry/socket/hostinet/socket_vfs2.go @@ -36,8 +36,11 @@ import ( type socketVFS2 struct { vfsfd vfs.FileDescription vfs.FileDescriptionDefaultImpl - // TODO(gvisor.dev/issue/1484): VFS1 stores internal metadata for hostinet. - // We should perhaps rely on the host, much like in hostfs. + + // We store metadata for hostinet sockets internally. Technically, we should + // access metadata (e.g. through stat, chmod) on the host for correctness, + // but this is not very useful for inet socket fds, which do not belong to a + // concrete file anyway. vfs.DentryMetadataFileDescriptionImpl socketOpsCommon |