diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2020-04-10 11:17:59 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-04-10 11:19:12 -0700 |
| commit | 1798d6cbee3360b09d3736069e15fd746e863bd2 (patch) | |
| tree | 36534478cc1624185626c14c6e94f730454554f0 /pkg/sentry/kernel/syscalls.go | |
| parent | 12b00c815638a28943c23d3be6ef09b955c6149e (diff) | |
Remove TODO from kernel.Stracer
The dependency strace=>kernel grew over time. strace also depends on
task's FD table and FSContext. It could be fixed with some interfaces
the other way, but then we're trading an interface for another, and
kernel.Stracer is likely cleaner.
Closes #155
PiperOrigin-RevId: 305909678
Diffstat (limited to 'pkg/sentry/kernel/syscalls.go')
| -rw-r--r-- | pkg/sentry/kernel/syscalls.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/pkg/sentry/kernel/syscalls.go b/pkg/sentry/kernel/syscalls.go index c9a2321b8..2e3565747 100644 --- a/pkg/sentry/kernel/syscalls.go +++ b/pkg/sentry/kernel/syscalls.go @@ -209,9 +209,6 @@ type Stracer interface { // SyscallEnter is called on syscall entry. // // The returned private data is passed to SyscallExit. - // - // TODO(gvisor.dev/issue/155): remove kernel imports from the strace - // package so that the type can be used directly. SyscallEnter(t *Task, sysno uintptr, args arch.SyscallArguments, flags uint32) interface{} // SyscallExit is called on syscall exit. |