diff options
| author | Dean Deng <deandeng@google.com> | 2020-10-03 09:24:34 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-10-03 09:26:25 -0700 |
| commit | e0aaf40e397072eba7944065cf2a820318cb266b (patch) | |
| tree | 43b3b0eb06369d54f393d5d7704d77efc829eea5 /pkg/sentry/fsimpl/sys/kcov.go | |
| parent | 55f835d1fdd0a5d9dca0b19a65cb748caf326f79 (diff) | |
Fix kcov enabling and disabling procedures.
- When the KCOV_ENABLE_TRACE ioctl is called with the trace kind KCOV_TRACE_PC,
the kcov mode should be set to KCOV_*MODE*_TRACE_PC.
- When the owning task of kcov exits, the memory mapping should not be cleared
so it can be used by other tasks.
- Add more tests (also tested on native Linux kcov).
PiperOrigin-RevId: 335202585
Diffstat (limited to 'pkg/sentry/fsimpl/sys/kcov.go')
| -rw-r--r-- | pkg/sentry/fsimpl/sys/kcov.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/sentry/fsimpl/sys/kcov.go b/pkg/sentry/fsimpl/sys/kcov.go index b75d70ae6..1a6749e53 100644 --- a/pkg/sentry/fsimpl/sys/kcov.go +++ b/pkg/sentry/fsimpl/sys/kcov.go @@ -104,7 +104,7 @@ func (fd *kcovFD) ConfigureMMap(ctx context.Context, opts *memmap.MMapOpts) erro func (fd *kcovFD) Release(ctx context.Context) { // kcov instances have reference counts in Linux, but this seems sufficient // for our purposes. - fd.kcov.Reset() + fd.kcov.Clear() } // SetStat implements vfs.FileDescriptionImpl.SetStat. |