summaryrefslogtreecommitdiffhomepage
path: root/pkg/sentry/fsimpl/kernfs
diff options
context:
space:
mode:
authorgVisor bot <gvisor-bot@google.com>2020-06-24 03:08:21 +0000
committergVisor bot <gvisor-bot@google.com>2020-06-24 03:08:21 +0000
commitcab13958a54419262aba2a0cd7f1075ed02c8ee0 (patch)
tree5b030cf3bcb54d91812bad68fe518aa87acecf76 /pkg/sentry/fsimpl/kernfs
parent02d43f5e75026d5d7e419391712733b34757aa41 (diff)
parent399c52888db609296fd1341ed0daa994ad2d02b0 (diff)
Merge release-20200608.0-118-g399c52888 (automated)
Diffstat (limited to 'pkg/sentry/fsimpl/kernfs')
-rw-r--r--pkg/sentry/fsimpl/kernfs/kernfs.go8
1 files changed, 3 insertions, 5 deletions
diff --git a/pkg/sentry/fsimpl/kernfs/kernfs.go b/pkg/sentry/fsimpl/kernfs/kernfs.go
index 55349f2a3..596de1edf 100644
--- a/pkg/sentry/fsimpl/kernfs/kernfs.go
+++ b/pkg/sentry/fsimpl/kernfs/kernfs.go
@@ -227,19 +227,17 @@ func (d *Dentry) destroy() {
// InotifyWithParent implements vfs.DentryImpl.InotifyWithParent.
//
-// TODO(gvisor.dev/issue/1479): Implement inotify.
+// Although Linux technically supports inotify on pseudo filesystems (inotify
+// is implemented at the vfs layer), it is not particularly useful. It is left
+// unimplemented until someone actually needs it.
func (d *Dentry) InotifyWithParent(events, cookie uint32, et vfs.EventType) {}
// Watches implements vfs.DentryImpl.Watches.
-//
-// TODO(gvisor.dev/issue/1479): Implement inotify.
func (d *Dentry) Watches() *vfs.Watches {
return nil
}
// OnZeroWatches implements vfs.Dentry.OnZeroWatches.
-//
-// TODO(gvisor.dev/issue/1479): Implement inotify.
func (d *Dentry) OnZeroWatches() {}
// InsertChild inserts child into the vfs dentry cache with the given name under