diff options
| author | Dean Deng <deandeng@google.com> | 2020-06-23 20:04:15 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-06-23 20:05:28 -0700 |
| commit | 399c52888db609296fd1341ed0daa994ad2d02b0 (patch) | |
| tree | 682a3873093a40dd1b4aca47f48f7a1c5ff4c63e /pkg/sentry/fsimpl/kernfs | |
| parent | 2189e0a660e8355167bee4939fffeb57f0312b5d (diff) | |
Resolve remaining inotify TODOs.
Also refactor HandleDeletion().
Updates #1479.
PiperOrigin-RevId: 317989000
Diffstat (limited to 'pkg/sentry/fsimpl/kernfs')
| -rw-r--r-- | pkg/sentry/fsimpl/kernfs/kernfs.go | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/pkg/sentry/fsimpl/kernfs/kernfs.go b/pkg/sentry/fsimpl/kernfs/kernfs.go index 55349f2a3..596de1edf 100644 --- a/pkg/sentry/fsimpl/kernfs/kernfs.go +++ b/pkg/sentry/fsimpl/kernfs/kernfs.go @@ -227,19 +227,17 @@ func (d *Dentry) destroy() { // InotifyWithParent implements vfs.DentryImpl.InotifyWithParent. // -// TODO(gvisor.dev/issue/1479): Implement inotify. +// Although Linux technically supports inotify on pseudo filesystems (inotify +// is implemented at the vfs layer), it is not particularly useful. It is left +// unimplemented until someone actually needs it. func (d *Dentry) InotifyWithParent(events, cookie uint32, et vfs.EventType) {} // Watches implements vfs.DentryImpl.Watches. -// -// TODO(gvisor.dev/issue/1479): Implement inotify. func (d *Dentry) Watches() *vfs.Watches { return nil } // OnZeroWatches implements vfs.Dentry.OnZeroWatches. -// -// TODO(gvisor.dev/issue/1479): Implement inotify. func (d *Dentry) OnZeroWatches() {} // InsertChild inserts child into the vfs dentry cache with the given name under |