summaryrefslogtreecommitdiffhomepage
path: root/pkg/sentry/fsimpl/gofer
diff options
context:
space:
mode:
authorgVisor bot <gvisor-bot@google.com>2020-08-24 18:33:52 +0000
committergVisor bot <gvisor-bot@google.com>2020-08-24 18:33:52 +0000
commit5c6a6440ff792f1db57a47dd1580b34e571c2967 (patch)
treece4fc64a67bc1dab3e3a8881a4ad19910e19c045 /pkg/sentry/fsimpl/gofer
parent3f11741804ad216c38cb2d821a269b8a3db64a2f (diff)
parentbae25d2a087d4c493b3335803dbfe53ab5505267 (diff)
Merge release-20200810.0-94-gbae25d2a0 (automated)
Diffstat (limited to 'pkg/sentry/fsimpl/gofer')
-rw-r--r--pkg/sentry/fsimpl/gofer/gofer.go7
1 files changed, 7 insertions, 0 deletions
diff --git a/pkg/sentry/fsimpl/gofer/gofer.go b/pkg/sentry/fsimpl/gofer/gofer.go
index c6696b9d8..81d34cfe3 100644
--- a/pkg/sentry/fsimpl/gofer/gofer.go
+++ b/pkg/sentry/fsimpl/gofer/gofer.go
@@ -703,6 +703,13 @@ type dentry struct {
locks vfs.FileLocks
// Inotify watches for this dentry.
+ //
+ // Note that inotify may behave unexpectedly in the presence of hard links,
+ // because dentries corresponding to the same file have separate inotify
+ // watches when they should share the same set. This is the case because it is
+ // impossible for us to know for sure whether two dentries correspond to the
+ // same underlying file (see the gofer filesystem section fo vfs/inotify.md for
+ // a more in-depth discussion on this matter).
watches vfs.Watches
}