diff options
| author | Andrei Vagin <avagin@google.com> | 2020-01-28 13:36:16 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-01-28 13:37:19 -0800 |
| commit | f263801a74d4ccac042b068d0928c8738e40af5b (patch) | |
| tree | 3e4fa2cf7a20ed4a38efb9b582262bfc8dfa12ab /pkg/sentry/fs/splice.go | |
| parent | 34fbd8446c386fb0136dad31ab6b173f17049a58 (diff) | |
fs/splice: don't report partial errors for special files
Special files can have additional requirements for granularity.
For example, read from eventfd returns EINVAL if a size is less 8 bytes.
Reported-by: syzbot+3905f5493bec08eb7b02@syzkaller.appspotmail.com
PiperOrigin-RevId: 292002926
Diffstat (limited to 'pkg/sentry/fs/splice.go')
| -rw-r--r-- | pkg/sentry/fs/splice.go | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/pkg/sentry/fs/splice.go b/pkg/sentry/fs/splice.go index 791d1526c..33da82868 100644 --- a/pkg/sentry/fs/splice.go +++ b/pkg/sentry/fs/splice.go @@ -167,11 +167,6 @@ func Splice(ctx context.Context, dst *File, src *File, opts SpliceOpts) (int64, if !srcPipe && !opts.SrcOffset { atomic.StoreInt64(&src.offset, src.offset+n) } - - // Don't report any errors if we have some progress without data loss. - if w.Err == nil { - err = nil - } } // Drop locks. |