diff options
| author | Adin Scannell <ascannell@google.com> | 2020-02-05 22:45:44 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-02-05 22:46:35 -0800 |
| commit | 1b6a12a768216a99a5e0428c42ea4faf79cf3b50 (patch) | |
| tree | 995d1ae4ba930d3c6b8fde0f3d1651db472c0dba /pkg/sentry/arch/arch_x86.go | |
| parent | f3d95607036b8a502c65aa7b3e8145227274dbbc (diff) | |
Add notes to relevant tests.
These were out-of-band notes that can help provide additional context
and simplify automated imports.
PiperOrigin-RevId: 293525915
Diffstat (limited to 'pkg/sentry/arch/arch_x86.go')
| -rw-r--r-- | pkg/sentry/arch/arch_x86.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/pkg/sentry/arch/arch_x86.go b/pkg/sentry/arch/arch_x86.go index a18093155..3db8bd34b 100644 --- a/pkg/sentry/arch/arch_x86.go +++ b/pkg/sentry/arch/arch_x86.go @@ -114,6 +114,10 @@ func newX86FPStateSlice() []byte { size, align := cpuid.HostFeatureSet().ExtendedStateSize() capacity := size // Always use at least 4096 bytes. + // + // For the KVM platform, this state is a fixed 4096 bytes, so make sure + // that the underlying array is at _least_ that size otherwise we will + // corrupt random memory. This is not a pleasant thing to debug. if capacity < 4096 { capacity = 4096 } |