diff options
| author | Adin Scannell <ascannell@google.com> | 2018-10-23 00:19:11 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2018-10-23 00:20:15 -0700 |
| commit | 75cd70ecc9abfd5daaefea04da5070a0e0d620dd (patch) | |
| tree | ff17ca619006a3bea596df09a58abbbf21c6528d /pkg/p9/client_file.go | |
| parent | c2c0f9cb7e8320de06ef280c6184bb6aeda71627 (diff) | |
Track paths and provide a rename hook.
This change also adds extensive testing to the p9 package via mocks. The sanity
checks and type checks are moved from the gofer into the core package, where
they can be more easily validated.
PiperOrigin-RevId: 218296768
Change-Id: I4fc3c326e7bf1e0e140a454cbacbcc6fd617ab55
Diffstat (limited to 'pkg/p9/client_file.go')
| -rw-r--r-- | pkg/p9/client_file.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/pkg/p9/client_file.go b/pkg/p9/client_file.go index 066639fda..992d1daf7 100644 --- a/pkg/p9/client_file.go +++ b/pkg/p9/client_file.go @@ -172,6 +172,9 @@ func (c *clientFile) SetAttr(valid SetAttrMask, attr SetAttr) error { } // Remove implements File.Remove. +// +// N.B. This method is no longer part of the file interface and should be +// considered deprecated. func (c *clientFile) Remove() error { // Avoid double close. if !atomic.CompareAndSwapUint32(&c.closed, 0, 1) { @@ -181,7 +184,6 @@ func (c *clientFile) Remove() error { // Send the remove message. if err := c.client.sendRecv(&Tremove{FID: c.fid}, &Rremove{}); err != nil { - log.Warningf("Tremove failed, losing FID %v: %v", c.fid, err) return err } |