summaryrefslogtreecommitdiffhomepage
path: root/pkg/fdchannel
diff options
context:
space:
mode:
authorAyush Ranjan <ayushranjan@google.com>2019-07-29 20:11:24 -0700
committergVisor bot <gvisor-bot@google.com>2019-07-29 20:12:37 -0700
commit8da9f8a12c51de41c4e048128a163fbb63679e4b (patch)
tree88dd537f92bf3b4d3e803bd7fdbf5b0693587607 /pkg/fdchannel
parentddf25e3331a18a74d0e01d74fee7f82963fe778c (diff)
Migrate from using io.ReadSeeker to io.ReaderAt.
This provides the following benefits: - We can now use pkg/fd package which does not take ownership of the file descriptor. So it does not close the fd when garbage collected. This reduces scope of errors from unexpected garbage collection of io.File. - It enforces the offset parameter in every read call. It does not affect the fd offset nor is it affected by it. Hence reducing scope of error of using stale offsets when reading. - We do not need to serialize the usage of any global file descriptor anymore. So this drops the mutual exclusion req hence reducing complexity and congestion. PiperOrigin-RevId: 260635174
Diffstat (limited to 'pkg/fdchannel')
0 files changed, 0 insertions, 0 deletions