diff options
| author | Dean Deng <deandeng@google.com> | 2020-07-01 22:03:14 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-07-01 22:04:42 -0700 |
| commit | 6c099d830091b3153e0dc39cf500dba441f45707 (patch) | |
| tree | 7aef39f986f41686eab49a39bfb14a85a26929dd /pkg/abi/linux/file.go | |
| parent | 514955c1a8f3927c928a57935d511ffbbf9c6f01 (diff) | |
Update preadv2/pwritev2 flag handling in vfs2.
We do not support RWF_SYNC/RWF_DSYNC and probably shouldn't silently accept
them, since the user may incorrectly believe that we are synchronizing I/O.
Remove the pwritev2 test verifying that we support these flags.
gvisor.dev/issue/2601 is the tracking bug for deciding which RWF_.* flags
we need and supporting them.
Updates #2923, #2601.
PiperOrigin-RevId: 319351286
Diffstat (limited to 'pkg/abi/linux/file.go')
| -rw-r--r-- | pkg/abi/linux/file.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/pkg/abi/linux/file.go b/pkg/abi/linux/file.go index 055ac1d7c..e11ca2d62 100644 --- a/pkg/abi/linux/file.go +++ b/pkg/abi/linux/file.go @@ -191,8 +191,9 @@ var DirentType = abi.ValueSet{ // Values for preadv2/pwritev2. const ( - // Note: gVisor does not implement the RWF_HIPRI feature, but the flag is - // accepted as a valid flag argument for preadv2/pwritev2. + // NOTE(b/120162627): gVisor does not implement the RWF_HIPRI feature, but + // the flag is accepted as a valid flag argument for preadv2/pwritev2 and + // silently ignored. RWF_HIPRI = 0x00000001 RWF_DSYNC = 0x00000002 RWF_SYNC = 0x00000004 |