diff options
| author | Jamie Liu <jamieliu@google.com> | 2020-08-19 11:50:54 -0700 |
|---|---|---|
| committer | Andrei Vagin <avagin@gmail.com> | 2020-09-09 17:53:10 -0700 |
| commit | 15f7c43b75f34635261df05003a4d58519bbe02e (patch) | |
| tree | 28ca2ac8a3ebead11ab66f7dbc8aab8610782a69 /g3doc | |
| parent | 55ad34a05b5b1a36e89d2269c9ca4918f81adf48 (diff) | |
Remove use of channels from p9.connState legacy transport.
- Remove sendDone, which currently does nothing whatsoever (errors sent to the
channel are completely unused). Instead, have request handlers log errors
they get from p9.send() inline.
- Replace recvOkay and recvDone with recvMu/recvIdle/recvShutdown. In addition
to being slightly clearer (IMO), this eliminates the p9.connState.service()
goroutine, significantly reducing the overhead involved in passing connection
receive access between goroutines (from buffered chan send/recv + unbuffered
chan send/recv to just a mutex unlock/lock).
PiperOrigin-RevId: 327476755
Diffstat (limited to 'g3doc')
0 files changed, 0 insertions, 0 deletions