summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorAdin Scannell <ascannell@google.com>2019-05-24 16:16:54 -0700
committerShentubot <shentubot@google.com>2019-05-24 16:18:09 -0700
commited5793808e9d97789c9494d86c9fa4ed62df46bb (patch)
treea25fdd1948f51b986a109052cd52e30f76bc4b73
parent6cdec6fadf7515a2d8feddcbc3058927897cbbc9 (diff)
Remove obsolete TODO.
We don't need to model internal interfaces after the system call interfaces (which are objectively worse and simply use a flag to distinguish between two logically different operations). PiperOrigin-RevId: 249916814 Change-Id: I45d02e0ec0be66b782a685b1f305ea027694cab9
-rw-r--r--pkg/sentry/fs/inode_operations.go3
1 files changed, 0 insertions, 3 deletions
diff --git a/pkg/sentry/fs/inode_operations.go b/pkg/sentry/fs/inode_operations.go
index 2ed89d482..ea089dfae 100644
--- a/pkg/sentry/fs/inode_operations.go
+++ b/pkg/sentry/fs/inode_operations.go
@@ -117,9 +117,6 @@ type InodeOperations interface {
// Remove removes the given named non-directory under dir.
//
// The caller must ensure that this operation is permitted.
- //
- // TODO(b/67778723): merge Remove and RemoveDirectory, Remove
- // just needs a type flag.
Remove(ctx context.Context, dir *Inode, name string) error
// RemoveDirectory removes the given named directory under dir.