diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2019-10-08 16:22:26 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2019-10-08 16:23:41 -0700 |
| commit | a357fe427b0bf64c8431ae31e33259ad60febac9 (patch) | |
| tree | 52d5f8c653199334fa43d0949f144f7429cc9f41 | |
| parent | b9cdbc26bc676caeda1fdc1b30956888116a12be (diff) | |
Remove stale TODO
PiperOrigin-RevId: 273630282
| -rw-r--r-- | runsc/boot/controller.go | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/runsc/boot/controller.go b/runsc/boot/controller.go index 26a60d5b8..a73c593ea 100644 --- a/runsc/boot/controller.go +++ b/runsc/boot/controller.go @@ -18,7 +18,6 @@ import ( "errors" "fmt" "os" - "path" "syscall" specs "github.com/opencontainers/runtime-spec/specs-go" @@ -234,13 +233,6 @@ func (cm *containerManager) Start(args *StartArgs, _ *struct{}) error { if args.CID == "" { return errors.New("start argument missing container ID") } - // Prevent CIDs containing ".." from confusing the sentry when creating - // /containers/<cid> directory. - // TODO(b/129293409): Once we have multiple independent roots, this - // check won't be necessary. - if path.Clean(args.CID) != args.CID { - return fmt.Errorf("container ID shouldn't contain directory traversals such as \"..\": %q", args.CID) - } if len(args.FilePayload.Files) < 4 { return fmt.Errorf("start arguments must contain stdin, stderr, and stdout followed by at least one file for the container root gofer") } |