diff options
author | Ghanan Gowripalan <ghanan@google.com> | 2021-02-04 17:58:58 -0800 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2021-02-04 18:00:54 -0800 |
commit | 71def1c5869af69e4127f2b07ebd7d5c62642597 (patch) | |
tree | 1cdb54640cd30bf9b199161cdab0ee422a1ce40c | |
parent | 41510d2746756818269b0bf8f3961f026a0c247c (diff) |
Lock ConnTrack before initializing buckets
PiperOrigin-RevId: 355751801
-rw-r--r-- | pkg/tcpip/stack/conntrack.go | 6 | ||||
-rw-r--r-- | pkg/tcpip/stack/iptables.go | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/pkg/tcpip/stack/conntrack.go b/pkg/tcpip/stack/conntrack.go index 54617f2e6..cdb435644 100644 --- a/pkg/tcpip/stack/conntrack.go +++ b/pkg/tcpip/stack/conntrack.go @@ -231,6 +231,12 @@ func newConn(orig, reply tupleID, manip manipType, hook Hook) *conn { return &conn } +func (ct *ConnTrack) init() { + ct.mu.Lock() + defer ct.mu.Unlock() + ct.buckets = make([]bucket, numBuckets) +} + // connFor gets the conn for pkt if it exists, or returns nil // if it does not. It returns an error when pkt does not contain a valid TCP // header. diff --git a/pkg/tcpip/stack/iptables.go b/pkg/tcpip/stack/iptables.go index 63832c200..52890f6eb 100644 --- a/pkg/tcpip/stack/iptables.go +++ b/pkg/tcpip/stack/iptables.go @@ -235,7 +235,7 @@ func (it *IPTables) ReplaceTable(id TableID, table Table, ipv6 bool) tcpip.Error // If iptables is being enabled, initialize the conntrack table and // reaper. if !it.modified { - it.connections.buckets = make([]bucket, numBuckets) + it.connections.init() it.startReaper(reaperDelay) } it.modified = true |