summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2019-05-03 09:41:08 -0700
committerShentubot <shentubot@google.com>2019-05-03 09:42:10 -0700
commit6b9ab65163528239c9fbf10053427513513e6ab0 (patch)
tree77e5e25d16839c05fdc5453b60d5967e050b7cb4
parent2d8e90b31102fa784f1657153db99d6fe52b4e9d (diff)
Skip flaky ClockGettime.CputimeId take 2
The test also times out when GCE machine has 2 CPUs. I cannot repro it locally with a 2 CPU cgroup though. Let's skip the test when there are 2 CPUs to stop the flakiness and retest it once the fix is available. PiperOrigin-RevId: 246523363 Change-Id: I9d9d922a5be3aa7bc91dff5a1807ca99f3f4a4f9
-rw-r--r--test/syscalls/linux/clock_gettime.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/test/syscalls/linux/clock_gettime.cc b/test/syscalls/linux/clock_gettime.cc
index 4c8ca1088..335a38d41 100644
--- a/test/syscalls/linux/clock_gettime.cc
+++ b/test/syscalls/linux/clock_gettime.cc
@@ -56,8 +56,9 @@ void spin_ns(int64_t ns) {
// Test that CLOCK_PROCESS_CPUTIME_ID is a superset of CLOCK_THREAD_CPUTIME_ID.
TEST(ClockGettime, CputimeId) {
// TODO(b/128871825,golang.org/issue/10958): Test times out when there is a
- // single core because one goroutine starves the others.
- SKIP_IF(std::thread::hardware_concurrency() == 1);
+ // small number of core because one goroutine starves the others.
+ printf("CPUS: %d\n", std::thread::hardware_concurrency());
+ SKIP_IF(std::thread::hardware_concurrency() <= 2);
constexpr int kNumThreads = 13; // arbitrary