diff options
| author | Adin Scannell <ascannell@google.com> | 2020-03-25 16:57:37 -0700 |
|---|---|---|
| committer | Adin Scannell <ascannell@google.com> | 2020-04-08 10:14:34 -0700 |
| commit | f888b9ce83c202bb77c1e29c3ee60cc485906536 (patch) | |
| tree | bcec43d0dc20584d5a3963154b8e2ef05b31bb99 | |
| parent | 928a7c60b8f02811e9c0fcbed0077efd55471cc4 (diff) | |
Fix unused result errors.
This fixes a bug in the proc net directory.
Updates #2243
| -rw-r--r-- | pkg/sentry/fsimpl/proc/task_net.go | 4 | ||||
| -rw-r--r-- | tools/nogo.json | 6 |
2 files changed, 2 insertions, 8 deletions
diff --git a/pkg/sentry/fsimpl/proc/task_net.go b/pkg/sentry/fsimpl/proc/task_net.go index 6b2a77328..6595fcee6 100644 --- a/pkg/sentry/fsimpl/proc/task_net.go +++ b/pkg/sentry/fsimpl/proc/task_net.go @@ -688,9 +688,9 @@ func (d *netSnmpData) Generate(ctx context.Context, buf *bytes.Buffer) error { if line.prefix == "Tcp" { tcp := stat.(*inet.StatSNMPTCP) // "Tcp" needs special processing because MaxConn is signed. RFC 2012. - fmt.Sprintf("%s: %s %d %s\n", line.prefix, sprintSlice(tcp[:3]), int64(tcp[3]), sprintSlice(tcp[4:])) + fmt.Fprintf(buf, "%s: %s %d %s\n", line.prefix, sprintSlice(tcp[:3]), int64(tcp[3]), sprintSlice(tcp[4:])) } else { - fmt.Sprintf("%s: %s\n", line.prefix, sprintSlice(toSlice(stat))) + fmt.Fprintf(buf, "%s: %s\n", line.prefix, sprintSlice(toSlice(stat))) } } return nil diff --git a/tools/nogo.json b/tools/nogo.json index f69999e50..09bda9212 100644 --- a/tools/nogo.json +++ b/tools/nogo.json @@ -44,11 +44,5 @@ "/pkg/sentry/platform/safecopy/safecopy_unsafe.go": "allowed: special case", "/pkg/sentry/vfs/mount_unsafe.go": "allowed: special case" } - }, - "unusedresult": { - "exclude_files": { - "/pkg/sentry/fsimpl/proc/task_net.go": "fix: result of fmt.Sprintf call not used", - "/pkg/sentry/fsimpl/proc/tasks_net.go": "fix: result of fmt.Sprintf call not used" - } } } |