diff options
author | Nicolas Lacasse <nlacasse@google.com> | 2019-08-01 14:56:29 -0700 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2019-08-01 14:57:49 -0700 |
commit | bad43772a1c3d0b2a755ab38caae12b6542fe7a2 (patch) | |
tree | 68d093250f5f4fa1e7ac5dbdb8c7f235a5ec076e | |
parent | f2b25aeac7b5ba44144d003fbb2ae657461b8e9b (diff) |
Drop reference on fs.Inode if Mount goes wrong.
PiperOrigin-RevId: 261203674
-rw-r--r-- | pkg/sentry/syscalls/linux/sys_mount.go | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/pkg/sentry/syscalls/linux/sys_mount.go b/pkg/sentry/syscalls/linux/sys_mount.go index 9080a10c3..8c13e2d82 100644 --- a/pkg/sentry/syscalls/linux/sys_mount.go +++ b/pkg/sentry/syscalls/linux/sys_mount.go @@ -109,9 +109,17 @@ func Mount(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall return 0, nil, syserror.EINVAL } - return 0, nil, fileOpOn(t, linux.AT_FDCWD, targetPath, true /* resolve */, func(root *fs.Dirent, d *fs.Dirent, _ uint) error { + if err := fileOpOn(t, linux.AT_FDCWD, targetPath, true /* resolve */, func(root *fs.Dirent, d *fs.Dirent, _ uint) error { + // Mount will take a reference on rootInode if successful. return t.MountNamespace().Mount(t, d, rootInode) - }) + }); err != nil { + // Something went wrong. Drop our ref on rootInode before + // returning the error. + rootInode.DecRef() + return 0, nil, err + } + + return 0, nil, nil } // Umount2 implements Linux syscall umount2(2). |