summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMichael Pratt <mpratt@google.com>2020-06-17 12:32:59 -0700
committergVisor bot <gvisor-bot@google.com>2020-06-17 12:34:33 -0700
commit6d806ee7198422973a2e4efa9b539de7792b933f (patch)
tree460a7f620751543e0470977979068b70a1618910
parente5d97cbcc1e64185b8fab1cf563c8754edd2e52e (diff)
Remove various uses of 'blacklist'
Updates #2972 PiperOrigin-RevId: 316942245
-rw-r--r--pkg/sentry/fs/host/tty.go6
-rw-r--r--pkg/sentry/fsimpl/host/tty.go6
-rw-r--r--test/runner/runner.go6
-rw-r--r--tools/nogo/matchers.go2
4 files changed, 10 insertions, 10 deletions
diff --git a/pkg/sentry/fs/host/tty.go b/pkg/sentry/fs/host/tty.go
index cb91355ab..82a02fcb2 100644
--- a/pkg/sentry/fs/host/tty.go
+++ b/pkg/sentry/fs/host/tty.go
@@ -308,9 +308,9 @@ func (t *TTYFileOperations) checkChange(ctx context.Context, sig linux.Signal) e
task := kernel.TaskFromContext(ctx)
if task == nil {
// No task? Linux does not have an analog for this case, but
- // tty_check_change is more of a blacklist of cases than a
- // whitelist, and is surprisingly permissive. Allowing the
- // change seems most appropriate.
+ // tty_check_change only blocks specific cases and is
+ // surprisingly permissive. Allowing the change seems
+ // appropriate.
return nil
}
diff --git a/pkg/sentry/fsimpl/host/tty.go b/pkg/sentry/fsimpl/host/tty.go
index 0fbc543b1..4ee9270cc 100644
--- a/pkg/sentry/fsimpl/host/tty.go
+++ b/pkg/sentry/fsimpl/host/tty.go
@@ -326,9 +326,9 @@ func (t *TTYFileDescription) checkChange(ctx context.Context, sig linux.Signal)
task := kernel.TaskFromContext(ctx)
if task == nil {
// No task? Linux does not have an analog for this case, but
- // tty_check_change is more of a blacklist of cases than a
- // whitelist, and is surprisingly permissive. Allowing the
- // change seems most appropriate.
+ // tty_check_change only blocks specific cases and is
+ // surprisingly permissive. Allowing the change seems
+ // appropriate.
return nil
}
diff --git a/test/runner/runner.go b/test/runner/runner.go
index f8baf61b0..5456e46a6 100644
--- a/test/runner/runner.go
+++ b/test/runner/runner.go
@@ -391,12 +391,12 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {
}
}
-// filterEnv returns an environment with the blacklisted variables removed.
-func filterEnv(env, blacklist []string) []string {
+// filterEnv returns an environment with the excluded variables removed.
+func filterEnv(env, exclude []string) []string {
var out []string
for _, kv := range env {
ok := true
- for _, k := range blacklist {
+ for _, k := range exclude {
if strings.HasPrefix(kv, k+"=") {
ok = false
break
diff --git a/tools/nogo/matchers.go b/tools/nogo/matchers.go
index bc5772303..32f099925 100644
--- a/tools/nogo/matchers.go
+++ b/tools/nogo/matchers.go
@@ -89,7 +89,7 @@ func (r resultExcluded) ShouldReport(d analysis.Diagnostic, _ *token.FileSet) bo
return false
}
}
- return true // Not blacklisted.
+ return true // Not excluded.
}
// andMatcher is a composite matcher.