diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2019-12-03 13:42:30 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2019-12-03 13:44:06 -0800 |
| commit | 154dcdec072ddad9e1c96b56e023d7f77fecf2ad (patch) | |
| tree | 2de49a318f3c62668656af4b941773bfefc06218 | |
| parent | 3e832bec1b48b95951c3b83eb5a7b70f29b1f10f (diff) | |
Remove watchdog TODO
I have not seen a false positive stuck task yet.
Biggest offender was whitelistfs which is going away.
PiperOrigin-RevId: 283613064
| -rw-r--r-- | pkg/sentry/watchdog/watchdog.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/pkg/sentry/watchdog/watchdog.go b/pkg/sentry/watchdog/watchdog.go index ecce6c69f..5e4611333 100644 --- a/pkg/sentry/watchdog/watchdog.go +++ b/pkg/sentry/watchdog/watchdog.go @@ -287,7 +287,9 @@ func (w *Watchdog) runTurn() { if !ok { // New stuck task detected. // - // TODO(b/65849403): Tasks blocked doing IO may be considered stuck in kernel. + // Note that tasks blocked doing IO may be considered stuck in kernel, + // unless they are surrounded b + // Task.UninterruptibleSleepStart/Finish. tc = &offender{lastUpdateTime: lastUpdateTime} stuckTasks.Increment() newTaskFound = true |