diff options
author | Adin Scannell <ascannell@google.com> | 2020-02-10 13:51:26 -0800 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2020-02-10 13:52:09 -0800 |
commit | a6f9361c2f7c5b46a200de1dc891a0ce059ad90e (patch) | |
tree | b65707f77f3049d2db518e9fb8f8d8df3770627b | |
parent | bb22ebd7fbfc66556b38df669be5c6372daba018 (diff) |
Add context to comments.
PiperOrigin-RevId: 294295852
-rw-r--r-- | pkg/sentry/fs/gofer/attr.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/pkg/sentry/fs/gofer/attr.go b/pkg/sentry/fs/gofer/attr.go index 71cccdc34..6db4b762d 100644 --- a/pkg/sentry/fs/gofer/attr.go +++ b/pkg/sentry/fs/gofer/attr.go @@ -88,8 +88,9 @@ func bsize(pattr p9.Attr) int64 { if pattr.BlockSize > 0 { return int64(pattr.BlockSize) } - // Some files may have no clue of their block size. Better not to report - // something misleading or buggy and have a safe default. + // Some files, particularly those that are not on a local file system, + // may have no clue of their block size. Better not to report something + // misleading or buggy and have a safe default. return usermem.PageSize } @@ -149,6 +150,7 @@ func links(valid p9.AttrMask, pattr p9.Attr) uint64 { } // This node is likely backed by a file system that doesn't support links. + // // We could readdir() and count children directories to provide an accurate // link count. However this may be expensive since the gofer may be backed by remote // storage. Instead, simply return 2 links for directories and 1 for everything else |