summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorZach Koopmans <zkoopmans@google.com>2020-08-19 09:48:55 -0700
committergVisor bot <gvisor-bot@google.com>2020-08-19 09:51:04 -0700
commit33317222917d805edd71f0d2ddd7a208bd57fc4c (patch)
treefc5de98d0058d74bf0faf29c634c3cd52216ae81
parent33c60b893fe8a0f039c781091bf96cbcd47ecc2d (diff)
Skip ECN test for native/linux tests.
Skip check for ECN bits in native/linux tests. General advice for the ECN field is to leave the setting to the kernel, so behavior of the test is undefined for different kernels. http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch07lev1sec6.html PiperOrigin-RevId: 327451414
-rw-r--r--test/syscalls/linux/socket_ip_unbound.cc2
1 files changed, 2 insertions, 0 deletions
diff --git a/test/syscalls/linux/socket_ip_unbound.cc b/test/syscalls/linux/socket_ip_unbound.cc
index 1c7b0cf90..8f7ccc868 100644
--- a/test/syscalls/linux/socket_ip_unbound.cc
+++ b/test/syscalls/linux/socket_ip_unbound.cc
@@ -217,6 +217,8 @@ TEST_P(IPUnboundSocketTest, InvalidLargeTOS) {
}
TEST_P(IPUnboundSocketTest, CheckSkipECN) {
+ // Test is inconsistant on different kernels.
+ SKIP_IF(!IsRunningOnGvisor());
auto socket = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
int set = 0xFF;
socklen_t set_sz = sizeof(set);