summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2018-08-21 14:34:00 -0700
committerShentubot <shentubot@google.com>2018-08-21 14:35:08 -0700
commit19ef2ad1fe82093548edbb00de536d4bcf328f2b (patch)
tree7004958fd4b35867f2d4e410f7a65d7582017c42
parenta854678bc36065379ca0b988410b4a8318747a3d (diff)
nonExclusiveFS is causing timeout with --race
Not sure why, just removed for now to unblock the tests. PiperOrigin-RevId: 209661403 Change-Id: I72785c071687d54e22bda9073d36b447d52a7018
-rw-r--r--runsc/container/container_test.go16
1 files changed, 6 insertions, 10 deletions
diff --git a/runsc/container/container_test.go b/runsc/container/container_test.go
index f9f7d75ea..4d44e7abe 100644
--- a/runsc/container/container_test.go
+++ b/runsc/container/container_test.go
@@ -213,8 +213,10 @@ const (
nonExclusiveFS
)
-var all = []configOption{overlay, kvm, nonExclusiveFS}
-var noOverlay = []configOption{kvm, nonExclusiveFS}
+// TODO: nonExclusiveFS was removed because it causes timeout
+// with --race. Put it back when bug is fixed.
+var all = []configOption{overlay, kvm}
+var noOverlay = []configOption{kvm}
// configs generates different configurations to run tests.
func configs(opts ...configOption) []*boot.Config {
@@ -557,10 +559,7 @@ func TestExec(t *testing.T) {
// be the next consecutive number after the last number from the checkpointed container.
func TestCheckpointRestore(t *testing.T) {
// Skip overlay because test requires writing to host file.
- //
- // TODO: Skip nonExclusiveFS because $TEST_TMPDIR mount is
- // mistakenly marked as RO after revalidation.
- for _, conf := range configs(kvm) {
+ for _, conf := range configs(noOverlay...) {
t.Logf("Running test with conf: %+v", conf)
dir, err := ioutil.TempDir(testutil.TmpDir(), "checkpoint-test")
@@ -711,10 +710,7 @@ func TestUnixDomainSockets(t *testing.T) {
)
// Skip overlay because test requires writing to host file.
- //
- // TODO: Skip nonExclusiveFS because $TEST_TMPDIR mount is
- // mistakenly marked as RO after revalidation.
- for _, conf := range configs(kvm) {
+ for _, conf := range configs(noOverlay...) {
t.Logf("Running test with conf: %+v", conf)
dir, err := ioutil.TempDir(testutil.TmpDir(), "uds-test")