diff options
| author | Ian Lewis <ianlewis@google.com> | 2021-05-10 17:27:08 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-05-10 17:29:07 -0700 |
| commit | 1699d702cbfcf6f34bd14327b644738f996feb3b (patch) | |
| tree | 287cc56e322faf3618b203038044a472925f26d7 | |
| parent | 6c349c675c49f1059efbcadb6b04123ab2357ca2 (diff) | |
Fix issue reviver
Fixes invocation of the Github issue reviver by including the required 'path'
command line option. Also updates the issue reviver to add a 'revived' label to
revived issues. Issues with a 'revived' label will no longer be marked as
stale.
PiperOrigin-RevId: 373046772
| -rw-r--r-- | .github/workflows/issue_reviver.yml | 2 | ||||
| -rw-r--r-- | .github/workflows/stale.yml | 2 | ||||
| -rw-r--r-- | tools/github/reviver/github.go | 5 |
3 files changed, 7 insertions, 2 deletions
diff --git a/.github/workflows/issue_reviver.yml b/.github/workflows/issue_reviver.yml index 3bd883035..f2d584ac0 100644 --- a/.github/workflows/issue_reviver.yml +++ b/.github/workflows/issue_reviver.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v2 if: github.repository == 'google/gvisor' - - run: make run TARGETS="//tools/github" ARGS="revive" + - run: make run TARGETS="//tools/github" ARGS="-path=. revive" if: github.repository == 'google/gvisor' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index a9e0a4717..ef13f019f 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -14,7 +14,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-label: 'stale' stale-pr-label: 'stale' - exempt-issue-labels: 'exported, type: bug, type: cleanup, type: enhancement, type: process, type: proposal, type: question' + exempt-issue-labels: 'revived, exported, type: bug, type: cleanup, type: enhancement, type: process, type: proposal, type: question' exempt-pr-labels: 'ready to pull, exported' stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.' stale-pr-message: 'This pull request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.' diff --git a/tools/github/reviver/github.go b/tools/github/reviver/github.go index c4b624f2a..d9773500e 100644 --- a/tools/github/reviver/github.go +++ b/tools/github/reviver/github.go @@ -110,6 +110,11 @@ func (b *GitHubBugger) Activate(todo *Todo) (bool, error) { return true, fmt.Errorf("failed to reactivate issue %d: %v", id, err) } + _, _, err = b.client.Issues.AddLabelsToIssue(ctx, b.owner, b.repo, id, []string{"revived"}) + if err != nil { + return true, fmt.Errorf("failed to set label on issue %d: %v", id, err) + } + cmt := &github.IssueComment{ Body: github.String(comment.String()), Reactions: &github.Reactions{Confused: github.Int(1)}, |