diff options
| author | Adin Scannell <ascannell@google.com> | 2021-01-12 20:31:08 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-01-12 20:33:28 -0800 |
| commit | e74aa25e2289878fdbfc7affdd2e031be3a99b31 (patch) | |
| tree | 5e9a986205da672e24e2755d090dc77197d378a3 /.buildkite | |
| parent | 62b4c2f5173dfa75387c079bd3dd6d5e5c3abae9 (diff) | |
Fix Go branch building.
Files removed from the working tree were not being properly removed from
the branch, leading to symbol conflicts while building. This requires the
change to 'git add --all' in the tools/go_branch.sh script.
But why was this not caught by CI? The "git clean -f" command by default
only cleans files in the current working directory. In order to clean the
whole tree recursively, we need to specify a pathspec, which is ".".
In addition to these fixes, re-add the "go tests" command to help prevent
this from happening again, since merges on the Go branch will happen in
GitHub actions for simplicity. The Go test is retained in BuildKite.
PiperOrigin-RevId: 351503804
Diffstat (limited to '.buildkite')
| -rw-r--r-- | .buildkite/pipeline.yaml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.buildkite/pipeline.yaml b/.buildkite/pipeline.yaml index f8bf00b50..93e4195d6 100644 --- a/.buildkite/pipeline.yaml +++ b/.buildkite/pipeline.yaml @@ -34,7 +34,7 @@ steps: label: ":golang: Go branch" commands: - tools/go_branch.sh - - git checkout go && git clean -f + - git checkout go && git clean -xf . - go build ./... # Release workflow. |