server: move default config setting logic inside BgpServer's methods

We have three ways to configure gobgp. config file, grpc api and native lib.
Every methods eventually call (*server.BgpServer).Start() or
(*server.BgpServer).AddNeighbor() when starting bgp server or adding
neighbors.

This commit moves default config setting logic inside them to remove
redundant code in grpc_server.go and simplify the usage of native lib.

Signed-off-by: ISHIDA Wataru <ishida.wataru@lab.ntt.co.jp>

1 files changed, 9 insertions, 0 deletions

diff --git a/server/server.go b/server/server.go
index 6841a854..ee8374a6 100644
--- a/server/server.go
+++ b/server/server.go
@@ -1151,6 +1151,10 @@ func (s *BgpServer) Start(c *config.Global) (err error) {
 			return
 		}
 
+		if err = config.SetDefaultGlobalConfigValues(c); err != nil {
+			return
+		}
+
 		if c.Config.Port > 0 {
 			acceptCh := make(chan *net.TCPConn, 4096)
 			for _, addr := range c.Config.LocalAddressList {
@@ -1645,6 +1649,11 @@ func (s *BgpServer) GetNeighbor() (l []*config.Neighbor) {
 }
 
 func (server *BgpServer) addNeighbor(c *config.Neighbor) error {
+
+	if err := config.SetDefaultNeighborConfigValues(c, server.bgpConfig.Global.Config.As); err != nil {
+		return err
+	}
+
 	addr := c.Config.NeighborAddress
 	if _, y := server.neighborMap[addr]; y {
 		return fmt.Errorf("Can't overwrite the exising peer: %s", addr)